dependencies: start using registry.k8s.io/pause:3.10 #125112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/sig windows release thanks |
k8s-ci-robot
added
sig/windows
3 tasks
k8s-ci-robot
added
area/kubeadm
area/kubectl
area/kubelet
area/provider/gcp
neolit123
commented
May 24, 2024
Comment on lines
-212
to
-217
| - path: cmd/kubeadm/app/util/template_test.go | ||
| match: validTmpl\s+= | ||
| - path: cmd/kubeadm/app/util/template_test.go | ||
| match: validTmplOut\s+= | ||
| - path: cmd/kubeadm/app/util/template_test.go | ||
| match: doNothing\s+= |
There was a problem hiding this comment.
these are not needed, unit tests were bound to a version, where they don't need to.
cmd/kubeadm has a couple of side cleanups in this PR to not have the image version in tests:
- flags_tests.go
- runtime_test.go
carlory
reviewed
May 24, 2024
carlory
reviewed
May 24, 2024
neolit123
force-pushed
the
1.31-add-v-to-windows-pause-after-promo
branch
from
ca9bb0a
to
935ceb8
Compare
neolit123
force-pushed
the
1.31-add-v-to-windows-pause-after-promo
branch
from
935ceb8
to
5e290eb
Compare
neolit123
commented
May 24, 2024
Comment on lines
-252
to
-253
| - path: test/utils/runners.go | ||
| match: registry.k8s.io\/pause:\d+\.\d+ |
There was a problem hiding this comment.
removed, using constants now
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d13da1e598f5f59fb15511a4b150bfb1692ddc4c
|
|
retest it. the failing test will be fixed by #125114 /test pull-kubernetes-e2e-gce |
dims
reviewed
May 24, 2024
| @@ -79,11 +79,11 @@ func TestBuildKubeletArgs(t *testing.T) { | |||
| nodeRegOpts: &kubeadmapi.NodeRegistrationOptions{ | |||
| CRISocket: "unix:///var/run/containerd/containerd.sock", | |||
| }, | |||
| pauseImage: "registry.k8s.io/pause:3.9", | |||
| pauseImage: "registry.k8s.io/pause:ver", | |||
dims
reviewed
May 24, 2024
| @@ -1211,7 +1212,7 @@ func MakePodSpec() v1.PodSpec { | |||
| return v1.PodSpec{ | |||
| Containers: []v1.Container{{ | |||
| Name: "pause", | |||
| Image: "registry.k8s.io/pause:3.9", | |||
| Image: imageutils.GetE2EImage(imageutils.Pause), | |||
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
update k/k to use pause 3.10
tracking issue:
#125092
Which issue(s) this PR fixes:
Fixes #125092
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: