Enable reporting test coverage to Coveralls from Shippable and disable per-PR coverage #12950
Conversation
|
GCE e2e build/test passed for commit 59fc39cbae38026b01d1078299525f977e38e5f6. |
|
GCE e2e build/test passed for commit c828bda077a66ce11b9a2e94ceac4dc1bf6b0aa6. |
|
GCE e2e build/test passed for commit af9d319606fd413346bfed1d5a77d78261ce0ba0. |
ixdy
force-pushed
the
coveralls
branch
2 times, most recently
from
b2f409a
to
01f0920
Compare
|
GCE e2e build/test passed for commit 052909c704da7e91cefcac62c6a474bdd1dec0b9. |
|
GCE e2e build/test passed for commit b2f409ad85680c867f4c61261361c286cb6c2742. |
|
GCE e2e build/test passed for commit 01f09209613af6d5e39428922ba4dc882fa082a3. |
|
GCE e2e build/test passed for commit dff95f7f990b1c03d98b599a1f48ee7602a8467c. |
ixdy
force-pushed
the
coveralls
branch
2 times, most recently
from
5ebce97
to
314ed6c
Compare
ixdy
changed the title
|
GCE e2e build/test passed for commit 5ebce97542941b266f785e0ad276391245b17c11. |
ixdy
changed the title
|
@zmerlynn @senorflor can one of you review this please? Unfortunately, I don't think Shippable decrypts the secure environment variables for PRs not from a branch in the kubernetes repo, so I don't have a good way to test that coverage reporting actually works until this is merged. Also, I have to duplicate a bunch of stuff because global environment variables don't work correctly with matrices on Shippable. Already filed Shippable/support#1808 for that one. |
|
Note that the names of the environment variables comes from https://coveralls.zendesk.com/hc/en-us/articles/201347419-Coveralls-currently-supports. |
|
GCE e2e build/test passed for commit 314ed6c45c95245f49543f083f9c48853cb2ca00. |
However, enable coverage collection only on merges - not on pull requests.
|
Shouldn't the Coveralls widget be reporting on this PR? |
|
Oh, you said NOT per-PR, that's right. |
|
This looks fine, assuming it passes CI. |
|
GCE e2e build/test passed for commit 82cb1e9d8b56d6ad5a91bfd8bd189d135e7b18ba. |
|
GCE e2e build/test passed for commit 6f548cf. |
|
@brendandburns why did the merge bot assign my own PR to me? |
|
@ixdy: Probably no self-assignment check? |
|
This passed all the CI tests ... can I get an LG? |
zmerlynn
added
the
lgtm
Enable reporting test coverage to Coveralls from Shippable and disable per-PR coverage
Fix Coveralls coverage reporting from Shippable by fixing path to
goverallsand adding necessary environment variables (I think).Also disable unit test coverage collection on PRs to speed up the build.