Make bash completions work on a Mac #13570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, the help flags are not actually disappearing because of this update to cobra, just their appearance in the docs.... |
k8s-github-robot
added
the
size/L
|
Labelling this PR as size/L |
eparis
force-pushed
the
completions-on-mac
branch
2 times, most recently
from
a22ce07
to
8a45deb
Compare
|
GCE e2e build/test failed for commit 8a45debba2f24a4be164ca47a9f6cf02c914bc98. |
|
ok to test |
|
Thanks @eparis. Could you split the spf13 upgrade into a separate PR please? |
ghost
assigned
|
Not really. All this commit does it update spf13/cobra and regen docs. Those need to be semi-atomic. |
|
Fair enough. Needs a rebase and merge conflict resolution. Then LGTM. |
eparis
force-pushed
the
completions-on-mac
branch
from
8a45deb
to
bf7646b
Compare
|
updated. Thanks! |
|
GCE e2e build/test passed for commit bf7646b. |
ghost
pushed a commit
that referenced
this pull request
Sep 4, 2015
Make bash completions work on a Mac
ghost
merged commit 
| @@ -109,7 +108,7 @@ $ kubectl scale --replicas=5 rc/foo rc/bar | |||
|
|
|||
| * [kubectl](kubectl.md) - kubectl controls the Kubernetes cluster manager | |||
|
|
|||
| ###### Auto generated by spf13/cobra at 2015-08-21 17:18:05.165785015 +0000 UTC | |||
| ###### Auto generated by spf13/cobra at 2015-09-03 21:06:22.471116954 +0000 UTC | |||
|
|
|||
| <!-- BEGIN MUNGE: GENERATED_ANALYTICS --> | |||
| @@ -83,7 +82,7 @@ kubectl version | |||
|
|
|||
| * [kubectl](kubectl.md) - kubectl controls the Kubernetes cluster manager | |||
|
|
|||
| ###### Auto generated by spf13/cobra at 2015-08-21 17:18:05.1688832 +0000 UTC | |||
| ###### Auto generated by spf13/cobra at 2015-09-03 21:06:22.476464324 +0000 UTC | |||
|
|
|||
| <!-- BEGIN MUNGE: GENERATED_ANALYTICS --> | |||
| []() | |||
There was a problem hiding this comment.
what is this ga analytics beacon tracker & badge ?!?? bad-ass. what (if any) open-source project does it stem from?
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.