Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static Consumption added to autoscaling_utils.go #14167

Merged
merged 1 commit into from Sep 21, 2015
Merged

Static Consumption added to autoscaling_utils.go #14167

merged 1 commit into from Sep 21, 2015

Conversation

socaa
Copy link

@socaa socaa commented Sep 18, 2015

Part of #11570

@piosz

@k8s-bot
Copy link

k8s-bot commented Sep 18, 2015

GCE e2e build/test failed for commit ce495dcdee1c1ead69f9c9f3aad5e01dc0fc9ba5.

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 18, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/M

@ixdy
Copy link
Member

ixdy commented Sep 18, 2015

This is failing to build:

# k8s.io/kubernetes/test/e2e
_output/local/go/src/k8s.io/kubernetes/test/e2e/horizontal_pod_autoscaling.go:45: undefined: NewResourceConsumer
_output/local/go/src/k8s.io/kubernetes/test/e2e/horizontal_pod_autoscaling.go:52: undefined: NewResourceConsumer
_output/local/go/src/k8s.io/kubernetes/test/e2e/horizontal_pod_autoscaling.go:59: undefined: NewResourceConsumer
_output/local/go/src/k8s.io/kubernetes/test/e2e/horizontal_pod_autoscaling.go:66: undefined: NewResourceConsumer
_output/local/go/src/k8s.io/kubernetes/test/e2e/horizontal_pod_autoscaling.go:75: undefined: NewResourceConsumer
_output/local/go/src/k8s.io/kubernetes/test/e2e/horizontal_pod_autoscaling.go:84: undefined: NewResourceConsumer
_output/local/go/src/k8s.io/kubernetes/test/e2e/horizontal_pod_autoscaling.go:93: undefined: NewResourceConsumer
_output/local/go/src/k8s.io/kubernetes/test/e2e/horizontal_pod_autoscaling.go:103: undefined: NewResourceConsumer
_output/local/go/src/k8s.io/kubernetes/test/e2e/horizontal_pod_autoscaling.go:110: undefined: NewResourceConsumer
_output/local/go/src/k8s.io/kubernetes/test/e2e/horizontal_pod_autoscaling.go:117: undefined: NewResourceConsumer
_output/local/go/src/k8s.io/kubernetes/test/e2e/horizontal_pod_autoscaling.go:117: too many errors

@socaa
Copy link
Author

socaa commented Sep 21, 2015

PTAL

@piosz
@ixdy

@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test passed for commit cd097e9fc97d07f2fbbb9550568a3e60cad43285.

@socaa socaa force-pushed the static-consumption branch 2 times, most recently from e692d9a to 45648ff Compare September 21, 2015 08:04
@socaa
Copy link
Author

socaa commented Sep 21, 2015

PTAL

@piosz

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 21, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test passed for commit 45648ff09a63a94fad32ebd773597e1101718805.

@socaa
Copy link
Author

socaa commented Sep 21, 2015

PTAL

@piosz

@piosz
Copy link
Member

piosz commented Sep 21, 2015

LGTM. Discussed some comments offline.

@piosz piosz added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Sep 21, 2015
@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test passed for commit 152991f.

@piosz piosz assigned piosz and unassigned ixdy Sep 21, 2015
@piosz piosz closed this Sep 21, 2015
@piosz piosz reopened this Sep 21, 2015
@piosz piosz closed this Sep 21, 2015
@piosz piosz reopened this Sep 21, 2015
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 21, 2015

GCE e2e build/test passed for commit 152991f.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Sep 21, 2015
Merge pull request #14167 from socaa/static-consumption
979bfc0 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 979bfc0 into kubernetes:master Sep 21, 2015
@piosz piosz mentioned this pull request Oct 5, 2015
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@piosz piosz

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@socaa @k8s-bot @k8s-github-robot @ixdy @piosz @googlebot