rkt: return non error if the pod doesn't exist in GetPodStatus() #14706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, GetPodStatus() will return error if the pod is never created. However we've never seen the sync loop fail because in the beginning of the loop, if the pod is not found, it will be created. This works fine except the pod that keeps crashing. Because the above logic will keep restarting the pod as if it's never created. This PR fixes the bug.
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
k8s-github-robot
added
the
size/S
|
Labelling this PR as size/S |
|
This makes the code behaves more like the docker counterpart.. :) |
|
@k8s-bot ok to test |
yujuhong
added
the
lgtm
|
Unit, integration and GCE e2e test build/test passed for commit 4309caf. |
|
Unit, integration and GCE e2e test build/test passed for commit 4309caf. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Unit, integration and GCE e2e build/test failed for commit 4309caf. |
|
rkt is not tested in e2e yet. |
|
Anyway will need to rebase after #14686 |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 2, 2015
Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, GetPodStatus() will return error if the pod is never
created. However we've never seen the sync loop fail because in the
beginning of the loop, if the pod is not found, it will be created.
This works fine except the pod that keeps crashing. Because the above
logic will keep restarting the pod as if it's never created.
This PR fixes the bug.
/cc @dchen1107 @yujuhong