Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Deployment tests in GKE #14750

Merged
merged 1 commit into from Sep 29, 2015
Merged

Disable Deployment tests in GKE #14750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion hack/jenkins/e2e.sh
View file
Open in desktop
Expand Up @@ -104,13 +104,14 @@ GCE_DEFAULT_SKIP_TESTS=(
)

# Tests which cannot be run on GKE, e.g. because they require
# master ssh access.
# master ssh access or experimental api.
GKE_REQUIRED_SKIP_TESTS=(
"Nodes"
"Etcd\sFailure"
"MasterCerts"
"Shell"
"Daemon\sset"
"Deployment"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the comment above, as it is now inaccurate. The reason this test is excluded is not because it requires SSH access, but because it requires access to experimental API's.
Also, please file an issue to remove this filter as soon as Deployments move out of experimental (and ideally a comment in the code that would change when it moves out of experimental, wherever that is).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is technically still accurate, as at least some of the other tests are skipped because they require ssh access to the master. Updated anyway, filed #14751.

)

# The following tests are known to be flaky, and are thus run only in their own
Expand Down