Use strong type for container ID #15124
Conversation
|
@timstclair Thanks for taking this important(though uninteresting)work!! Appreciate! 🎩 LGTM. |
k8s-github-robot
added
the
size/L
|
Labelling this PR as size/L |
|
Unit, integration and GCE e2e test build/test passed for commit a3bacfca3492a81ab9ed0d8be5576bf742c5e3ab. |
|
LGTM. Thanks for taking on this! |
yujuhong
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test failed for commit a3bacfca3492a81ab9ed0d8be5576bf742c5e3ab. |
|
Sorry, this needs a rebase since #14686 gets merged. I think we'd better hold other kubelet PRs so we can get this in first, otherwise there will be a lot of rebasing work.. /cc @kubernetes/goog-node |
k8s-github-robot
added
the
needs-rebase
|
Agreed. #15051 is probably going to merge first. I will try to block the rest until this one lands. |
timstclair
force-pushed
the
container-id
branch
from
a3bacfc
to
a26e052
Compare
Change all references to the container ID in pkg/kubelet/... to the strong type defined in pkg/kubelet/container: ContainerID The motivation for this change is to make the format of the ID unambiguous, specifically whether or not it includes the runtime prefix (e.g. "docker://").
timstclair
force-pushed
the
container-id
branch
from
a26e052
to
551eff6
Compare
|
Rebased and changed |
yujuhong
added
lgtm
|
GCE e2e test build/test passed for commit a26e0525652e670722827e68865cecf820ed199e. |
|
GCE e2e build/test failed for commit 551eff6. |
k8s-github-robot
removed
the
needs-rebase
|
Continuous integration appears to have missed, closing and re-opening to trigger it |
|
ok to test |
|
GCE e2e test build/test passed for commit 551eff6. |
|
We have to manually merge this one since it is block a lot of node related prs. cc/ @janetkuo, oncall. Thanks! |
Use strong type for container ID
Change all references to the container ID in pkg/kubelet/... to the
strong type defined in pkg/kubelet/container: ContainerID
The motivation for this change is to make the format of the ID
unambiguous, specifically whether or not it includes the runtime
prefix (e.g. "docker://").
@yifan-gu
cc/ @yujuhong @dchen1107 @vishh