Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating k8petstore dev tooling+ dockerfiles+ go source. #15452

Merged
merged 1 commit into from
Oct 13, 2015
Merged

Updating k8petstore dev tooling+ dockerfiles+ go source. #15452

merged 1 commit into from
Oct 13, 2015

Conversation

jayunit100
Copy link
Member

No description provided.

@k8s-bot
Copy link

k8s-bot commented Oct 12, 2015

GCE e2e build/test failed for commit 46a85cd11880e60ec460ee491a711c4264123337.

@jayunit100
Copy link
Member Author

These are a series of dev improvements I made when I took a look at k8petstore this afternoon. In particular.

  • No need for vagrant, docker-machine solves the dev problem for us. So I removed a lot of unnecessary stuff.
  • Docker go containers were deprecated. Updated to the new ones.
  • Updated docs around publicip/nodeport.
  • Added single easy to use dev/test script that is all in one, and starts / builds the app +containers from zero.

@k8s-bot
Copy link

k8s-bot commented Oct 12, 2015

GCE e2e test build/test passed for commit 1221f7f40523e53fde517dbf8bedf50e808afe03.

@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 12, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

@jayunit100
Cleaning/Updating k8petstore dev tooling and build fixing, moving web…
c897798 
…server to

main.go.  Replacing vagrant tooling with docker-machine.
@k8s-bot
Copy link

k8s-bot commented Oct 12, 2015

GCE e2e test build/test passed for commit c897798.

@brendandburns brendandburns added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Oct 12, 2015
@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Oct 13, 2015
Merge pull request #15452 from jayunit100/petstore-dev
eeeb5e0 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit eeeb5e0 into kubernetes:master Oct 13, 2015
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@wojtek-t wojtek-t mentioned this pull request Oct 13, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jayunit100 @k8s-bot @k8s-github-robot @k8s-teamcity-mesosphere @googlebot @brendandburns @wojtek-t