-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Vagrant VMs to Fedora 23 #15998
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,11 +22,7 @@ set -o pipefail | |
# See: https://github.com/mitchellh/vagrant/issues/2430 | ||
hostnamectl set-hostname ${MASTER_NAME} | ||
|
||
if [[ "$(grep 'VERSION_ID' /etc/os-release)" =~ ^VERSION_ID=21 ]]; then | ||
# Workaround to vagrant inability to guess interface naming sequence | ||
# Tell system to abandon the new naming scheme and use eth* instead | ||
rm -f /etc/sysconfig/network-scripts/ifcfg-enp0s3 | ||
|
||
if [[ "$(grep 'VERSION_ID' /etc/os-release)" =~ ^VERSION_ID=23 ]]; then | ||
# Disable network interface being managed by Network Manager (needed for Fedora 21+) | ||
NETWORK_CONF_PATH=/etc/sysconfig/network-scripts/ | ||
if_to_edit=$( find ${NETWORK_CONF_PATH}ifcfg-* | xargs grep -l VAGRANT-BEGIN ) | ||
|
@@ -108,8 +104,8 @@ fi | |
if ! which /usr/libexec/cockpit-ws &>/dev/null; then | ||
|
||
pushd /etc/yum.repos.d | ||
wget https://copr.fedoraproject.org/coprs/sgallagh/cockpit-preview/repo/fedora-21/sgallagh-cockpit-preview-fedora-21.repo | ||
yum install -y cockpit cockpit-kubernetes | ||
wget https://copr.fedoraproject.org/coprs/sgallagh/cockpit-preview/repo/fedora-22/sgallagh-cockpit-preview-fedora-22.repo | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had a problem with wget being missing on the fedora 23 libvirt image. Do the opscode boxes include it by default? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @marun Forgot to reply sorry. No, wget doesn't exit under fedora. See above^
|
||
dnf install -y cockpit cockpit-kubernetes | ||
popd | ||
|
||
systemctl enable cockpit.socket | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,11 +22,7 @@ set -o pipefail | |
# See: https://github.com/mitchellh/vagrant/issues/2430 | ||
hostnamectl set-hostname ${NODE_NAME} | ||
|
||
if [[ "$(grep 'VERSION_ID' /etc/os-release)" =~ ^VERSION_ID=21 ]]; then | ||
# Workaround to vagrant inability to guess interface naming sequence | ||
# Tell system to abandon the new naming scheme and use eth* instead | ||
rm -f /etc/sysconfig/network-scripts/ifcfg-enp0s3 | ||
|
||
if [[ "$(grep 'VERSION_ID' /etc/os-release)" =~ ^VERSION_ID=23 ]]; then | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the fixup this block encloses still required for the opscode boxes? |
||
# Disable network interface being managed by Network Manager (needed for Fedora 21+) | ||
NETWORK_CONF_PATH=/etc/sysconfig/network-scripts/ | ||
if_to_edit=$( find ${NETWORK_CONF_PATH}ifcfg-* | xargs grep -l VAGRANT-BEGIN ) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intention with this conditional was to limit the fixup to Fedora 21. The fixup appeared unnecessary (and occasionally problematic) for Fedora 22 and 23, at least for libvirt. Do the opscode boxes for 23 have different configuration from the fedora libvirt image that does not require this block?