Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal pod autoscaler is not stable #16275

Closed
jszczepkowski opened this issue Oct 26, 2015 · 3 comments
Closed

Horizontal pod autoscaler is not stable #16275

jszczepkowski opened this issue Oct 26, 2015 · 3 comments
Assignees
@jszczepkowski
Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.
Milestone
v1.1

Comments

@jszczepkowski
Copy link
Contributor

Horizontal pod autoscaler makes decision to scale down after 1 minute from the previous scale down, although downscaleForbiddenWindow is 5 minutes. This causes flakiness of hpa e2e tests with stability checks:

http://kubekins.dls.corp.google.com/job/kubernetes-e2e-gce-autoscaling/1496/consoleFull
@jszczepkowski jszczepkowski self-assigned this Oct 26, 2015
@jszczepkowski
Copy link
Contributor Author

CC @piosz

@jszczepkowski jszczepkowski added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Oct 26, 2015
@jszczepkowski jszczepkowski added this to the v1.1 milestone Oct 26, 2015
jszczepkowski added a commit to jszczepkowski/kubernetes that referenced this issue Oct 26, 2015
@jszczepkowski
Fixed resetting last scale time in HPA status.
de25a3b 
Fixed resetting last scale time in HPA status. Fixes kubernetes#16275.
@jszczepkowski jszczepkowski mentioned this issue Oct 26, 2015
Merged
@jszczepkowski
Copy link
Contributor Author

Found root cause: HPA was incorrectly resetting last scale time during status update when there was no rescale.

@jszczepkowski
Copy link
Contributor Author

CC @derekwaynecarr @mdshuai

@piosz piosz mentioned this issue Oct 26, 2015
Closed
@piosz piosz mentioned this issue Oct 27, 2015
Merged
jszczepkowski added a commit to jszczepkowski/kubernetes that referenced this issue Oct 27, 2015
@jszczepkowski
Fixed resetting last scale time in HPA status.
d574aa1 
Fixed resetting last scale time in HPA status. Fixes kubernetes#16275.
@jszczepkowski jszczepkowski mentioned this issue Oct 27, 2015
Merged
RichieEscarez pushed a commit to RichieEscarez/kubernetes that referenced this issue Dec 4, 2015
@jszczepkowski @RichieEscarez
Fixed resetting last scale time in HPA status.
ca859d1 
Fixed resetting last scale time in HPA status. Fixes kubernetes#16275.
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this issue Dec 1, 2016
@jszczepkowski
Fixed resetting last scale time in HPA status.
38b6f37 
Fixed resetting last scale time in HPA status. Fixes kubernetes#16275.
shouhong pushed a commit to shouhong/kubernetes that referenced this issue Feb 14, 2017
@jszczepkowski
Fixed resetting last scale time in HPA status.
ba2963a 
Fixed resetting last scale time in HPA status. Fixes kubernetes#16275.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jszczepkowski jszczepkowski

Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@bgrant0607 @jszczepkowski