Refactor code for creating Cacher. #16584
Conversation
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
|
GCE e2e test build/test passed for commit 24101ce27033d7a007ea09cbf87eac87c904296e. |
|
@k8s-bot unit test this please |
1 similar comment
|
@k8s-bot unit test this please |
|
@lavalamp - PTAL |
| NewListFunc: func() runtime.Object { return &api.PodList{} }, | ||
| } | ||
| storageInterface = storage.NewCacher(config) | ||
| storageInterface = storage.NewCacher(1000, s, nil, &api.Pod{}, prefix, true, newListFunc) |
There was a problem hiding this comment.
I was actually hoping to construct the cacher outside and pass it in-- if that's too hard, then I'll take this, though.
There was a problem hiding this comment.
It's different for every resource, so yeah - that would be difficult.
There was a problem hiding this comment.
(Discussed in person: I suggested passing a construction function in instead of the boolean)
wojtek-t
force-pushed
the
refactor_use_cacher
branch
from
24101ce
to
ed0abe5
Compare
|
@lavalamp - PTAL [Any better suggestions for names are appreciated] |
|
Labelling this PR as size/L |
k8s-github-robot
added
size/L
| @@ -111,10 +111,56 @@ type Cacher struct { | |||
| ListFromCache bool | |||
| } | |||
|
|
|||
| type DecorateStorage func( | |||
| Interface, int, Versioner, runtime.Object, string, bool, | |||
| func() runtime.Object) Interface | |||
There was a problem hiding this comment.
Can you name the parameters? + add godoc.
I might call this a storage factory...
wojtek-t
force-pushed
the
refactor_use_cacher
branch
from
ed0abe5
to
8f385c5
Compare
|
@lavalamp - PTAL |
|
GCE e2e test build/test passed for commit ed0abe5bdf87cdccafcea8d19416ee06c9b824a2. |
|
GCE e2e test build/test passed for commit 8f385c5. |
lavalamp
added
the
lgtm
|
LGTM, thanks for bearing with me :) |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 8f385c5. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Requested in #16496