Add new "metrics" API group. #16621
Add new "metrics" API group. #16621
Conversation
timstclair
added
area/api
|
Labelling this PR as size/XXL |
k8s-github-robot
added
the
size/XXL
|
GCE e2e test build/test passed for commit 2856973ce46d01691bd4b14fd5f8e9c54d2fd438. |
| panic(err) | ||
| } | ||
| return interfaces.Codec | ||
| interfaces, err := latest.GroupOrDie(g.Group).InterfacesFor(g.GroupVersionUnderTest) |
There was a problem hiding this comment.
Thank you for fixing this!
|
LGTM. |
|
Probably you need to import it the install package in https://github.com/kubernetes/kubernetes/blob/master/pkg/master/import_known_versions.go as well. LGTM otherwise. |
|
I think the first iteration (just Raw{Node,Pod,Container}) will only be served by the kubelet, so I don't think we want to import it to the master? What does importing to the master do? |
|
Per offline-discussion, master doesn't need to know the metric API, so no need to import it there. Thanks. LGTM. |
caesarxuchao
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test failed for commit 2856973ce46d01691bd4b14fd5f8e9c54d2fd438. |
k8s-github-robot
added
the
needs-rebase
|
@timstclair - can you please rebase? |
This commit only adds 2 placeholder structs to the API, for the purposes of separating the API group setup from the API discussion.
timstclair
force-pushed
the
metrics-lite
branch
from
2856973
to
5cd5b80
Compare
timstclair
added
lgtm
|
Rebased. |
k8s-github-robot
removed
the
needs-rebase
|
GCE e2e test build/test passed for commit 5cd5b80. |
|
@k8s-bot unit test this |
|
LGTM |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 5cd5b80. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Forked from #16458 for the purposes of separating the discussion of the API group setup from the discussion of the API itself. I added 2 "placeholder" types (which will eventually be fleshed out) for purposes of demonstrating the API setup, and giving the code-generation tools something to generate.
From the metrics group proposal
First steps towards #12483
cc/ @vishh @dchen1107 @lavalamp