Add OpenStack cloud provider #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anguslees
force-pushed
the
openstack-provider
branch
4 times, most recently
from
accac53
to
d2c7132
Compare
| limitations under the License. | ||
| */ | ||
|
|
||
| package openstack_cloud |
|
Overall looks pretty good, mostly just style suggestions. |
|
Also can you create a MAINTAINERS file so we know who to bug when we break things? :) |
|
Thanks, updated. I shamelessly copied from the AWS provider, so many of your style comments could be applied there too, fwiw. |
anguslees
force-pushed
the
openstack-provider
branch
from
d2c7132
to
d71342c
Compare
|
I probably didn't notice on account of "AWS" being so much shorter, thanks for bearing with me :) It looks like the gophercloud package didn't actually get copied into the dependencies, which is why travis is failing you. I'm not a godeps wizard, but I think you need to do something involving the godeps save command. You added the right incantation to the .json file, you just need to also get the package into the Godeps dir (please do that in a separate commit!). |
Note this also pulls in: github.com/kr/text github.com/mitchellh/mapstructure github.com/racker/perigee github.com/tonnerre/golang-pretty
anguslees
force-pushed
the
openstack-provider
branch
from
d71342c
to
fffa052
Compare
|
LGTM thanks! |
csrwng
pushed a commit
to csrwng/kubernetes
that referenced
this pull request
Aug 29, 2023
…try-shim OCPBUGS-18149: UPSTREAM: <carry>: retry etcd Unavailable errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far only implements Instances() interface.