-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate deep copies with framework. #16854
Merged
k8s-github-robot
merged 1 commit into
kubernetes:master
from
wojtek-t:deep_copy_generator
Nov 12, 2015
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,366 @@ | ||
/* | ||
Copyright 2015 The Kubernetes Authors All rights reserved. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package generators | ||
|
||
import ( | ||
"io" | ||
"os" | ||
"path/filepath" | ||
"strings" | ||
|
||
"k8s.io/kubernetes/cmd/libs/go2idl/args" | ||
"k8s.io/kubernetes/cmd/libs/go2idl/generator" | ||
"k8s.io/kubernetes/cmd/libs/go2idl/namer" | ||
"k8s.io/kubernetes/cmd/libs/go2idl/types" | ||
|
||
"github.com/golang/glog" | ||
) | ||
|
||
// TODO: This is created only to reduce number of changes in a single PR. | ||
// Remove it and use PublicNamer instead. | ||
func deepCopyNamer() *namer.NameStrategy { | ||
return &namer.NameStrategy{ | ||
Join: func(pre string, in []string, post string) string { | ||
return strings.Join(in, "_") | ||
}, | ||
PrependPackageNames: 1, | ||
} | ||
} | ||
|
||
// NameSystems returns the name system used by the generators in this package. | ||
func NameSystems() namer.NameSystems { | ||
return namer.NameSystems{ | ||
"public": deepCopyNamer(), | ||
"raw": namer.NewRawNamer("", nil), | ||
} | ||
} | ||
|
||
// DefaultNameSystem returns the default name system for ordering the types to be | ||
// processed by the generators in this package. | ||
func DefaultNameSystem() string { | ||
return "public" | ||
} | ||
|
||
func Packages(_ *generator.Context, arguments *args.GeneratorArgs) generator.Packages { | ||
boilerplate, err := arguments.LoadGoBoilerplate() | ||
if err != nil { | ||
glog.Fatalf("Failed loading boilerplate: %v", err) | ||
} | ||
|
||
packages := generator.Packages{} | ||
for _, inputDir := range arguments.InputDirs { | ||
packages = append(packages, | ||
&generator.DefaultPackage{ | ||
PackageName: filepath.Base(inputDir), | ||
PackagePath: inputDir, | ||
HeaderText: append(boilerplate, []byte( | ||
` | ||
// This file was autogenerated by the command: | ||
// $ `+strings.Join(os.Args, " ")+` | ||
// Do not edit it manually! | ||
|
||
`)...), | ||
GeneratorFunc: func(c *generator.Context) (generators []generator.Generator) { | ||
generators = []generator.Generator{} | ||
// TODO: Check whether anything will be generated. | ||
generators = append(generators, NewGenDeepCopy("deep_copy_generated", inputDir)) | ||
return generators | ||
}, | ||
FilterFunc: func(c *generator.Context, t *types.Type) bool { | ||
switch t.Kind { | ||
case types.Func, types.Chan: | ||
// These types can't be copied. | ||
return false | ||
case types.Unknown, types.Unsupported: | ||
// These types are explicitly ignored. | ||
return false | ||
case types.Array: | ||
// We don't support arrays. | ||
return false | ||
} | ||
// Also, filter out private types. | ||
if strings.ToLower(t.Name.Name[:1]) == t.Name.Name[:1] { | ||
return false | ||
} | ||
return true | ||
}, | ||
}) | ||
} | ||
return packages | ||
} | ||
|
||
const ( | ||
apiPackagePath = "k8s.io/kubernetes/pkg/api" | ||
conversionPackagePath = "k8s.io/kubernetes/pkg/conversion" | ||
) | ||
|
||
// genDeepCopy produces a file with a set for a single type. | ||
type genDeepCopy struct { | ||
generator.DefaultGen | ||
targetPackage string | ||
imports *generator.ImportTracker | ||
typesForInit []*types.Type | ||
} | ||
|
||
func NewGenDeepCopy(sanitizedName, targetPackage string) generator.Generator { | ||
return &genDeepCopy{ | ||
DefaultGen: generator.DefaultGen{ | ||
OptionalName: sanitizedName, | ||
}, | ||
targetPackage: targetPackage, | ||
imports: generator.NewImportTracker(), | ||
typesForInit: make([]*types.Type, 0), | ||
} | ||
} | ||
|
||
func (g *genDeepCopy) Namers(c *generator.Context) namer.NameSystems { | ||
// Have the raw namer for this file track what it imports. | ||
return namer.NameSystems{"raw": namer.NewRawNamer(g.targetPackage, g.imports)} | ||
} | ||
|
||
// Filter ignores all but one type because we're making a single file per type. | ||
func (g *genDeepCopy) Filter(c *generator.Context, t *types.Type) bool { | ||
// Filter out all types not copyable within the package. | ||
copyable := g.copyableWithinPackage(t) | ||
if copyable { | ||
g.typesForInit = append(g.typesForInit, t) | ||
} | ||
return copyable | ||
} | ||
|
||
func (g *genDeepCopy) copyableWithinPackage(t *types.Type) bool { | ||
// TODO: We should generate public DeepCopy functions per directory, instead | ||
// of generating everything everywhere. | ||
// This is done that way only to minimize number of changes per PR. | ||
// Once this is done, we should replace HasPrefix with: | ||
//if t.Name.Package != g.targetPackage { | ||
// return false | ||
//} | ||
if !strings.HasPrefix(t.Name.Package, "k8s.io/kubernetes/") { | ||
return false | ||
} | ||
if types.ExtractCommentTags("+", t.CommentLines)["gencopy"] == "false" { | ||
return false | ||
} | ||
// TODO: Consider generating functions for other kinds too. | ||
return t.Kind == types.Struct | ||
} | ||
|
||
func (g *genDeepCopy) isOtherPackage(pkg string) bool { | ||
if pkg == g.targetPackage { | ||
return false | ||
} | ||
if strings.HasSuffix(pkg, "\""+g.targetPackage+"\"") { | ||
return false | ||
} | ||
return true | ||
} | ||
|
||
func (g *genDeepCopy) Imports(c *generator.Context) (imports []string) { | ||
importLines := []string{} | ||
if g.isOtherPackage(apiPackagePath) { | ||
importLines = append(importLines, "api \""+apiPackagePath+"\"") | ||
} | ||
if g.isOtherPackage(conversionPackagePath) { | ||
importLines = append(importLines, "conversion \""+conversionPackagePath+"\"") | ||
} | ||
for _, singleImport := range g.imports.ImportLines() { | ||
if g.isOtherPackage(singleImport) { | ||
importLines = append(importLines, singleImport) | ||
} | ||
} | ||
return importLines | ||
} | ||
|
||
func (g *genDeepCopy) Init(c *generator.Context, w io.Writer) error { | ||
sw := generator.NewSnippetWriter(w, c, "$", "$") | ||
sw.Do("func init() {\n", nil) | ||
sw.Do("if err := api.Scheme.AddGeneratedDeepCopyFuncs(\n", nil) | ||
for _, t := range g.typesForInit { | ||
sw.Do("deepCopy_$.|public$,\n", t) | ||
} | ||
sw.Do("); err != nil {\n", nil) | ||
sw.Do("// if one of the deep copy functions is malformed, detect it immediately.\n", nil) | ||
sw.Do("panic(err)\n", nil) | ||
sw.Do("}\n", nil) | ||
sw.Do("}\n\n", nil) | ||
return sw.Error() | ||
} | ||
|
||
// GenerateType makes the body of a file implementing a set for type t. | ||
func (g *genDeepCopy) GenerateType(c *generator.Context, t *types.Type, w io.Writer) error { | ||
sw := generator.NewSnippetWriter(w, c, "$", "$") | ||
sw.Do("func deepCopy_$.|public$(in $.|raw$, out *$.|raw$, c *conversion.Cloner) error {\n", t) | ||
g.generateFor(t, sw) | ||
sw.Do("return nil\n", nil) | ||
sw.Do("}\n\n", nil) | ||
return sw.Error() | ||
} | ||
|
||
// we use the system of shadowing 'in' and 'out' so that the same code is valid | ||
// at any nesting level. This makes the autogenerator easy to understand, and | ||
// the compiler shouldn't care. | ||
func (g *genDeepCopy) generateFor(t *types.Type, sw *generator.SnippetWriter) { | ||
var f func(*types.Type, *generator.SnippetWriter) | ||
switch t.Kind { | ||
case types.Builtin: | ||
f = g.doBuiltin | ||
case types.Map: | ||
f = g.doMap | ||
case types.Slice: | ||
f = g.doSlice | ||
case types.Struct: | ||
f = g.doStruct | ||
case types.Interface: | ||
f = g.doInterface | ||
case types.Pointer: | ||
f = g.doPointer | ||
case types.Alias: | ||
f = g.doAlias | ||
default: | ||
f = g.doUnknown | ||
} | ||
f(t, sw) | ||
} | ||
|
||
func (g *genDeepCopy) doBuiltin(t *types.Type, sw *generator.SnippetWriter) { | ||
sw.Do("*out = in\n", nil) | ||
} | ||
|
||
func (g *genDeepCopy) doMap(t *types.Type, sw *generator.SnippetWriter) { | ||
sw.Do("*out = make($.|raw$)\n", t) | ||
sw.Do("for key, val := range in {\n", nil) | ||
if t.Key.IsAssignable() { | ||
if t.Elem.IsAssignable() { | ||
sw.Do("(*out)[key] = val\n", nil) | ||
} else { | ||
if g.copyableWithinPackage(t.Elem) { | ||
sw.Do("newVal := new($.|raw$)\n", t.Elem) | ||
sw.Do("if err := deepCopy_$.|public$(val, newVal, c); err != nil {\n", t.Elem) | ||
sw.Do("return err\n", nil) | ||
sw.Do("}\n", nil) | ||
sw.Do("(*out)[key] = *newVal\n", nil) | ||
} else { | ||
sw.Do("if newVal, err := c.DeepCopy(val); err != nil {\n", nil) | ||
sw.Do("return err\n", nil) | ||
sw.Do("} else {\n", nil) | ||
sw.Do("(*out)[key] = newVal.($.|raw$)\n", t.Elem) | ||
sw.Do("}\n", nil) | ||
} | ||
} | ||
} else { | ||
// TODO: Implement it when necessary. | ||
sw.Do("// FIXME: Copying unassignable keys unsupported $.|raw$\n", t.Key) | ||
} | ||
sw.Do("}\n", nil) | ||
} | ||
|
||
func (g *genDeepCopy) doSlice(t *types.Type, sw *generator.SnippetWriter) { | ||
sw.Do("*out = make($.|raw$, len(in))\n", t) | ||
if t.Elem.Kind == types.Builtin { | ||
sw.Do("copy(*out, in)\n", nil) | ||
} else { | ||
sw.Do("for i := range in {\n", nil) | ||
if t.Elem.IsAssignable() { | ||
sw.Do("(*out)[i] = in[i]\n", nil) | ||
} else if g.copyableWithinPackage(t.Elem) { | ||
sw.Do("if err := deepCopy_$.|public$(in[i], &(*out)[i], c); err != nil {\n", t.Elem) | ||
sw.Do("return err\n", nil) | ||
sw.Do("}\n", nil) | ||
} else { | ||
sw.Do("if newVal, err := c.DeepCopy(in[i]); err != nil {\n", nil) | ||
sw.Do("return err\n", nil) | ||
sw.Do("} else {\n", nil) | ||
sw.Do("(*out)[i] = newVal.($.|raw$)\n", t.Elem) | ||
sw.Do("}\n", nil) | ||
} | ||
sw.Do("}\n", nil) | ||
} | ||
} | ||
|
||
func (g *genDeepCopy) doStruct(t *types.Type, sw *generator.SnippetWriter) { | ||
for _, m := range t.Members { | ||
args := map[string]interface{}{ | ||
"type": m.Type, | ||
"name": m.Name, | ||
} | ||
switch m.Type.Kind { | ||
case types.Builtin: | ||
sw.Do("out.$.name$ = in.$.name$\n", args) | ||
case types.Map, types.Slice, types.Pointer: | ||
sw.Do("if in.$.name$ != nil {\n", args) | ||
sw.Do("in, out := in.$.name$, &out.$.name$\n", args) | ||
g.generateFor(m.Type, sw) | ||
sw.Do("} else {\n", nil) | ||
sw.Do("out.$.name$ = nil\n", args) | ||
sw.Do("}\n", nil) | ||
case types.Struct: | ||
if g.copyableWithinPackage(m.Type) { | ||
sw.Do("if err := deepCopy_$.type|public$(in.$.name$, &out.$.name$, c); err != nil {\n", args) | ||
sw.Do("return err\n", nil) | ||
sw.Do("}\n", nil) | ||
} else { | ||
sw.Do("if newVal, err := c.DeepCopy(in.$.name$); err != nil {\n", args) | ||
sw.Do("return err\n", nil) | ||
sw.Do("} else {\n", nil) | ||
sw.Do("out.$.name$ = newVal.($.type|raw$)\n", args) | ||
sw.Do("}\n", nil) | ||
} | ||
default: | ||
if m.Type.Kind == types.Alias && m.Type.Underlying.Kind == types.Builtin { | ||
sw.Do("out.$.name$ = in.$.name$\n", args) | ||
} else { | ||
sw.Do("if newVal, err := c.DeepCopy(in.$.name$); err != nil {\n", args) | ||
sw.Do("return err\n", nil) | ||
sw.Do("} else {\n", nil) | ||
sw.Do("out.$.name$ = newVal.($.type|raw$)\n", args) | ||
sw.Do("}\n", nil) | ||
} | ||
} | ||
} | ||
} | ||
|
||
func (g *genDeepCopy) doInterface(t *types.Type, sw *generator.SnippetWriter) { | ||
// TODO: Add support for interfaces. | ||
g.doUnknown(t, sw) | ||
} | ||
|
||
func (g *genDeepCopy) doPointer(t *types.Type, sw *generator.SnippetWriter) { | ||
sw.Do("*out = new($.Elem|raw$)\n", t) | ||
if t.Elem.Kind == types.Builtin { | ||
sw.Do("**out = *in", nil) | ||
} else if g.copyableWithinPackage(t.Elem) { | ||
sw.Do("if err := deepCopy_$.|public$(*in, *out, c); err != nil {\n", t.Elem) | ||
sw.Do("return err\n", nil) | ||
sw.Do("}\n", nil) | ||
} else { | ||
sw.Do("if newVal, err := c.DeepCopy(*in); err != nil {\n", nil) | ||
sw.Do("return err\n", nil) | ||
sw.Do("} else {\n", nil) | ||
sw.Do("**out = newVal.($.|raw$)\n", t.Elem) | ||
sw.Do("}\n", nil) | ||
} | ||
} | ||
|
||
func (g *genDeepCopy) doAlias(t *types.Type, sw *generator.SnippetWriter) { | ||
// TODO: Add support for aliases. | ||
g.doUnknown(t, sw) | ||
} | ||
|
||
func (g *genDeepCopy) doUnknown(t *types.Type, sw *generator.SnippetWriter) { | ||
sw.Do("// FIXME: Type $.|raw$ is unsupported.\n", t) | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still one issue that we need to support at the framework level. Basically if you look into generated file below (generated.go), it doesn't compile.
It's because "rawType" doesn't take into consideration in which package it is producing code. So even if we are referencing ab object from package "pkg" inside "pkg" package, it will still use "pkg.type" instead of just "type".
@lavalamp FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, we can fix that by making raw namer take an additional arg, of the package it's in. Then each generator that needs this can construct the raw namer with this arg. I can make this change, but probably won't have time for a few days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - that's what I thought about.
I will try to send out a separate PR for it (if I manage to do it today).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - I've sent out #17009 out for review.