Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install libapparmor1 in kubekins-test image #17268

Merged
merged 1 commit into from Nov 16, 2015

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Nov 14, 2015

Recent versions of Docker are dynamically linked, so when we run the verification tests in the kubekins-test image, docker-in-docker fails, due to a missing shared library:

docker: error while loading shared libraries: libapparmor.so.1: cannot open shared object file: No such file or directory
!!! Error in ./hack/update-api-reference-docs.sh:53
  'docker run -u $(id -u) --rm -v $V1_TMP_IN_HOST:/output:z -v ${SWAGGER_PATH}:/swagger-source:z gcr.io/google_containers/gen-swagger-docs:v4 v1 https://raw.githubusercontent.com/kubernetes/kubernetes/master/pkg/api/v1/register.go' exited with status 127
Call stack:
  1: ./hack/update-api-reference-docs.sh:53 main(...)
Exiting with status 1
!!! Error in ./hack/../hack/verify-api-reference-docs.sh:34
  '"./hack/update-api-reference-docs.sh" "${OUTPUT_DIR}"' exited with status 1
Call stack:
  1: ./hack/../hack/verify-api-reference-docs.sh:34 main(...)
Exiting with status 1
FAILED

Per moby/moby#15024 it seems this is WAI, and the workarounds are to either include the library dependency in the docker mount or install the library in the container. The latter seemed less fragile for now.

I've tested this locally, but I haven't pushed a new image (yet), so this will fail on PR Jenkins. If you're happy with the changes, I'll push the image to gcr.io, then re-run unit tests to verify everything is still good.

@kubernetes/goog-testing

@ixdy ixdy force-pushed the jenkins-test-image-apparmor branch from 5975477 to 896d04d Compare November 14, 2015 01:18
@k8s-bot
Copy link

k8s-bot commented Nov 14, 2015

GCE e2e build/test failed for commit 597547777a93106ba8e0cb6f7e8bbec23c329669.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 14, 2015

GCE e2e test build/test passed for commit 896d04d.

@j3ffml j3ffml added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2015
@j3ffml
Copy link
Contributor

j3ffml commented Nov 14, 2015

lgtm, go ahead and push

@piosz
Copy link
Member

piosz commented Nov 16, 2015

@k8s-bot unit test this please

@wojtek-t
Copy link
Member

@ixdy - unit tests are failing with the following error:
"Tag 0.3 not found in repository gcr.io/google_containers/kubekins-test"

Can you please push this first, before merging this PR so that we can test it?

@ixdy
Copy link
Member Author

ixdy commented Nov 16, 2015

@k8s-bot unit test this please

@ixdy
Copy link
Member Author

ixdy commented Nov 16, 2015

it's now been pushed to gcr.io

@ixdy
Copy link
Member Author

ixdy commented Nov 16, 2015

I misunderstood the error message from docker as thinking this had already been pushed. It's actually been pushed to gcr.io now.

@k8s-bot unit test this

@ixdy
Copy link
Member Author

ixdy commented Nov 16, 2015

@k8s-oncall FYI we may want to manually merge this ASAP - it'll let me enable additional Jenkins slaves for the PR queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-infra lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants