New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install libapparmor1 in kubekins-test image #17268
Conversation
5975477
to
896d04d
Compare
GCE e2e build/test failed for commit 597547777a93106ba8e0cb6f7e8bbec23c329669. |
Labelling this PR as size/XS |
GCE e2e test build/test passed for commit 896d04d. |
lgtm, go ahead and push |
@k8s-bot unit test this please |
@ixdy - unit tests are failing with the following error: Can you please push this first, before merging this PR so that we can test it? |
@k8s-bot unit test this please |
it's now been pushed to gcr.io |
I misunderstood the error message from docker as thinking this had already been pushed. It's actually been pushed to gcr.io now. @k8s-bot unit test this |
@k8s-oncall FYI we may want to manually merge this ASAP - it'll let me enable additional Jenkins slaves for the PR queue. |
Install libapparmor1 in kubekins-test image
Recent versions of Docker are dynamically linked, so when we run the verification tests in the kubekins-test image, docker-in-docker fails, due to a missing shared library:
Per moby/moby#15024 it seems this is WAI, and the workarounds are to either include the library dependency in the docker mount or install the library in the container. The latter seemed less fragile for now.
I've tested this locally, but I haven't pushed a new image (yet), so this will fail on PR Jenkins. If you're happy with the changes, I'll push the image to gcr.io, then re-run unit tests to verify everything is still good.
@kubernetes/goog-testing