-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start using kubelet internal PodStatus #17420
Merged
k8s-github-robot
merged 1 commit into
kubernetes:master
from
Random-Liu:use-raw-pod-status-in-docker
Dec 5, 2015
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Random-Liu Can we move this to runtime package so it can be reused by rkt as well?
For the DockerPrefix, is there any reason we can't add DockerPrefix in the
kubecontainer.ContainerStatus.Id
?cc @yujuhong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the DockerPrefix, we can just use
String()
ofcontainerStatus.ID
, if we want to move this function to runtime package in the future.However, for now it seems that we couldn't move it to runtime package.
Because we directly set exited container to
Terminated
state here, but in fact some of them should be inWaiting
state. They are just failed to be restarted in lastSyncPod()
and should be restarted in the future. For those containers, we'll set them toWaiting
with the help of reason cache in the following part ofConvertPodStatusToAPIPodStatus()
(Although there seems to be a little bug in that part now #17971).I'm not sure whether there is similar logic like this in rkt. @yifan-gu
And we also plan to move the reason cache logic up to Kubelet layer #18172 , after that I think we'll never need these kinds of convert functions in runtime interface any more. :)
/cc @yujuhong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Random-Liu OK I see. I think rkt needs the similar logic, and use a reason cache to change the status from
Terminted
toWaiting
.BTW why there is two
else if
here? Can we make it a function to check the reason ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yifan-gu, the code was patched over time. I expect rewriting this would improves the readability a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yujuhong @yifan-gu Yeah, that part is really confusing, =..=