Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a separate event client in kubelet #17476

Merged
merged 1 commit into from
Nov 25, 2015
Merged

add a separate event client in kubelet #17476

merged 1 commit into from
Nov 25, 2015

Conversation

jiangyaoguo
Copy link
Contributor

If event-qps was given, use a separate client to record events in kubelet.
Ref #14702

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 19, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 19, 2015

GCE e2e test build/test passed for commit 4b1579c526c201519a827f2c86f1a4344e61d47f.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 19, 2015

GCE e2e test build/test passed for commit 7e2e4ab065e65b210c4807c4748be219046097b1.

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 19, 2015

GCE e2e test build/test passed for commit f7f9777459d567371d99e29931d937eb809ccb02.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@yujuhong
Copy link
Contributor

@jiangyaoguo, I'd rather always create a separate client for events. Could you do that? Thanks

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2015
@jiangyaoguo jiangyaoguo force-pushed the add-separate-client-for-events branch 2 times, most recently from aa36b83 to d70e500 Compare November 20, 2015 17:24
@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 20, 2015
@yujuhong
Copy link
Contributor

jenkins failure: Generated docs are out of date. Please run hack/update-generated-docs.sh

@yujuhong
Copy link
Contributor

/cc @dchen1107 @wojtek-t @gmarek

@k8s-bot
Copy link

k8s-bot commented Nov 20, 2015

GCE e2e test build/test passed for commit 417c904eb9f02df160cf34dcf98388095d43e6c2.

@k8s-bot
Copy link

k8s-bot commented Nov 20, 2015

GCE e2e test build/test passed for commit aa36b83434c49b84766cf2ed75daaac588b82a99.

@k8s-bot
Copy link

k8s-bot commented Nov 20, 2015

GCE e2e test build/test passed for commit d70e50020b66f1915cb1a22400c3892a81728f70.

@k8s-bot
Copy link

k8s-bot commented Nov 20, 2015

GCE e2e test build/test passed for commit b06d3fa61080cbf285c6bbff7a183d91fb32b427.

@yujuhong yujuhong added ok-to-merge lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-merge labels Nov 23, 2015
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2015
@wojtek-t
Copy link
Member

@jiangyaoguo - can you please rebase?

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 24, 2015
@yujuhong yujuhong added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 24, 2015

GCE e2e test build/test passed for commit e3ea9d7.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Nov 25, 2015

GCE e2e test build/test passed for commit e3ea9d7.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Nov 25, 2015
Merge pull request #17476 from jiangyaoguo/add-separate-client-for-ev…
4a9b0fc 
…ents

Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 4a9b0fc into kubernetes:master Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yujuhong yujuhong

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jiangyaoguo @k8s-github-robot @k8s-bot @yujuhong @wojtek-t @k8s-teamcity-mesosphere @googlebot