Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SELinuxOptions to emptyDir e2e #17577

Merged
merged 1 commit into from Mar 16, 2016
Merged

Add SELinuxOptions to emptyDir e2e #17577

merged 1 commit into from Mar 16, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 20, 2015

This enables the tests to use the kubelet's SELinux labeling.
Otherwise SELinux will prevent access and the tests fail.

@pmorie

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 20, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@ixdy ixdy assigned pmorie and unassigned ixdy Nov 20, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 20, 2015

GCE e2e build/test failed for commit 1c8a4e9e6f092195ee2fea03db00817c8a51b7f1.

@ixdy
Copy link
Member

ixdy commented Nov 20, 2015

/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/empty_dir.go:75
Nov 20 11:47:39.483: Failed to create pod: pods "pod-8e5f8bc2-8fbf-11e5-8315-42010af0226b" is forbidden: pod.Spec.SecurityContext.SELinuxOptions is forbidden

This PR probably requires more thought.

@ghost
Copy link
Author

ghost commented Nov 20, 2015

/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/empty_dir.go:75
Nov 20 11:47:39.483: Failed to create pod: pods "pod-8e5f8bc2-8fbf-11e5-8315-42010af0226b" is forbidden: pod.Spec.SecurityContext.SELinuxOptions is forbidden

This PR probably requires more thought.

Hmm.. yeah... we need to either enable SecurityContext or not merge this. The problem is without this PR the tests will fail on systems where selinux is enabled.

@k8s-bot
Copy link

k8s-bot commented Nov 23, 2015

GCE e2e build/test failed for commit 8c0be8246ed636edcbe31fbf594c95c35f6f88b9.

@ghost
Copy link
Author

ghost commented Dec 1, 2015

@pmorie could you take a look at this. It seems SecurityContext is still forbidden in the test suite.

This enables the tests to use the kubelet's SELinux labeling.
Otherwise SELinux will prevent access and the tests fail.
@k8s-bot
Copy link

k8s-bot commented Feb 25, 2016

GCE e2e build/test failed for commit d43372b.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@ghost
Copy link
Author

ghost commented Feb 26, 2016

This should pass now that #21004 is merged.
@k8s-bot test this. issue #IGNORE

@ghost
Copy link
Author

ghost commented Feb 26, 2016

@k8s-bot test this. issue #IGNORE

@k8s-bot
Copy link

k8s-bot commented Feb 26, 2016

GCE e2e build/test passed for commit d43372b.

@ghost
Copy link
Author

ghost commented Feb 26, 2016

Aright all green! @ixdy @pmorie PTAL

@k8s-bot
Copy link

k8s-bot commented Feb 26, 2016

GCE e2e build/test failed for commit d43372b.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@ghost
Copy link
Author

ghost commented Mar 1, 2016

@k8s-bot test this. issue #20916

@k8s-bot
Copy link

k8s-bot commented Mar 1, 2016

GCE e2e build/test passed for commit d43372b.

@pmorie
Copy link
Member

pmorie commented Mar 11, 2016

@swagiaal does the tests in this PR have the right labels? Do they need to be relabeled?

@ghost
Copy link
Author

ghost commented Mar 14, 2016

@pmorie it looks like they received the correct label here #20183

@pmorie pmorie added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed cla: yes labels Mar 15, 2016
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Mar 15, 2016

GCE e2e build/test passed for commit d43372b.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 16, 2016

GCE e2e build/test passed for commit d43372b.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Mar 16, 2016
@k8s-github-robot k8s-github-robot merged commit eb0e25f into kubernetes:master Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants