Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled HPA e2e tests for 1.1 release #17639

Merged
merged 1 commit into from
Nov 23, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions hack/jenkins/e2e.sh
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ REBOOT_SKIP_TESTS=(
# Specialized tests which should be skipped by default for projects.
GCE_DEFAULT_SKIP_TESTS=(
"${REBOOT_SKIP_TESTS[@]}"
"Autoscaling\sSuite"
"Reboot"
"ServiceLoadBalancer"
)
Expand Down Expand Up @@ -161,7 +160,6 @@ AWS_REQUIRED_SKIP_TESTS=(

# Tests which kills or restarts components and/or nodes.
DISRUPTIVE_TESTS=(
"Autoscaling\sSuite.*scale\scluster"
"DaemonRestart"
"Etcd\sfailure"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change.
Scaling cluster is a disruptive test and I think it should be left here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline.

"Nodes\sResize"
Expand All @@ -185,8 +183,6 @@ GCE_FLAKY_TESTS=(
# comments below, and for poorly implemented tests, please quote the
# issue number tracking speed improvements.
GCE_SLOW_TESTS=(
# TODO: add deployment test here once it will become stable
"Autoscaling\sSuite.*via\sreplicationController"
# Before enabling this loadbalancer test in any other test list you must
# make sure the associated project has enough quota. At the time of this
# writing a GCE project is allowed 3 backend services by default. This
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/horizontal_pod_autoscaling.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ var _ = Describe("Horizontal pod autoscaling", func() {
})

// CPU tests via replication controllers
It(fmt.Sprintf(titleUp, "[Autoscaling Suite]", kindRC), func() {
It(fmt.Sprintf(titleUp, "[Skipped][Autoscaling Suite]", kindRC), func() {
scaleUp("rc", kindRC, rc, f)
})
It(fmt.Sprintf(titleDown, "[Autoscaling Suite]", kindRC), func() {
It(fmt.Sprintf(titleDown, "[Skipped][Autoscaling Suite]", kindRC), func() {
scaleDown("rc", kindRC, rc, f)
})
})
Expand Down