New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aws-sdk-go to v1.0.x #17733
Update aws-sdk-go to v1.0.x #17733
Conversation
cc @justinsb |
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
1 similar comment
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
Labelling this PR as size/XS |
ok to test |
GCE e2e test build/test passed for commit 3cb168ce2646237764a0d9fadb4ee75dc87df014. |
GCE e2e test build/test passed for commit 8b76743995a37804f676dcd7fd5752f2fbcde84b. |
LGTM. @justinsb FYI |
Continuous integration appears to have missed, closing and re-opening to trigger it |
PR changed after LGTM, removing LGTM. |
GCE e2e test build/test passed for commit 994979cc14c2a58bd36f2e6e90723478d79c59cd. |
LGTM |
Continuous integration appears to have missed, closing and re-opening to trigger it |
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
GCE e2e build/test failed for commit 994979cc14c2a58bd36f2e6e90723478d79c59cd. |
hack/verify-godeps.sh fails for you PR Can you please fix that? |
@wojtek-t Looks like I missed part of the go-jmespath dependency. Should be fixed now. |
PR changed after LGTM, removing LGTM. |
GCE e2e test build/test passed for commit dff49c73351f01dc68ce858b9ff978f92a74b4c7. |
GCE e2e test build/test passed for commit f2e43b04ebdbae93dd75012dc85a963c38cb7ca9. |
The unit test failure looks like a flake, unrelated to this PR. Rerunning...
|
@k8s-bot unit test this |
(I just wanted to say thank you @tpounds for persisting with this!) |
@justinsb No problem! |
@k8s-bot unit test this |
Same old unit test flakes, being tracked elsewhere. Try again. @k8s-bot unit test this
|
@k8s-bot test this Tests are more than 48 hours old. Re-running tests. |
GCE e2e test build/test passed for commit f2e43b04ebdbae93dd75012dc85a963c38cb7ca9. |
@quinton-hoole I've rebased again to pick up flake test fixes. |
PR changed after LGTM, removing LGTM. |
GCE e2e test build/test passed for commit bbc181d. |
@k8s-bot unit test this |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test failed for commit bbc181d. |
Good gracious, this is like giving birth to barbed wire. |
So how do we get 1.0.7 now? :-) I tried, but I'm stuck in godep hell (camlistore has recently deleted pkg/errorutil and godep doesn't fetch the version that was pinned in Godeps.json). |
@therc Do you have an open PR to upgrade the SDK to v1.0.7? If not, I can take a look a bit later today to see what it will take to upgrade to the latest version. |
I think I might have figured it ten seconds ago. I'll file a PR in a few hours. |
Updates AWS cloud provider to use the v1.0.x release which is now officially supported for production use.
see: https://aws.amazon.com/blogs/aws/now-available-version-1-0-of-the-aws-sdk-for-go/