Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk-go to v1.0.x #17733

Merged
3 commits merged into from Jan 5, 2016
Merged

Update aws-sdk-go to v1.0.x #17733

3 commits merged into from Jan 5, 2016

Conversation

tpounds
Copy link
Contributor

@tpounds tpounds commented Nov 24, 2015

Updates AWS cloud provider to use the v1.0.x release which is now officially supported for production use.

see: https://aws.amazon.com/blogs/aws/now-available-version-1-0-of-the-aws-sdk-for-go/

@tpounds
Copy link
Contributor Author

tpounds commented Nov 24, 2015

cc @justinsb

@k8s-bot
Copy link

k8s-bot commented Nov 24, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Nov 24, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 24, 2015
@ghost
Copy link

ghost commented Nov 24, 2015

ok to test

@k8s-bot
Copy link

k8s-bot commented Nov 24, 2015

GCE e2e test build/test passed for commit 3cb168ce2646237764a0d9fadb4ee75dc87df014.

@k8s-bot
Copy link

k8s-bot commented Nov 25, 2015

GCE e2e test build/test passed for commit 8b76743995a37804f676dcd7fd5752f2fbcde84b.

@ghost
Copy link

ghost commented Nov 25, 2015

LGTM. @justinsb FYI

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2015
@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 26, 2015

GCE e2e test build/test passed for commit 994979cc14c2a58bd36f2e6e90723478d79c59cd.

@ghost
Copy link

ghost commented Nov 30, 2015

LGTM

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2015
@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

GCE e2e build/test failed for commit 994979cc14c2a58bd36f2e6e90723478d79c59cd.

@wojtek-t
Copy link
Member

@tpounds

hack/verify-godeps.sh fails for you PR

Can you please fix that?

@tpounds
Copy link
Contributor Author

tpounds commented Nov 30, 2015

@wojtek-t Looks like I missed part of the go-jmespath dependency. Should be fixed now.

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2015
@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

GCE e2e test build/test passed for commit dff49c73351f01dc68ce858b9ff978f92a74b4c7.

@k8s-bot
Copy link

k8s-bot commented Dec 30, 2015

GCE e2e test build/test passed for commit f2e43b04ebdbae93dd75012dc85a963c38cb7ca9.

@ghost
Copy link

ghost commented Dec 30, 2015

The unit test failure looks like a flake, unrelated to this PR. Rerunning...

FAIL    k8s.io/kubernetes/pkg/registry/generic/etcd 3.236s

@ghost
Copy link

ghost commented Dec 30, 2015

@k8s-bot unit test this

@justinsb
Copy link
Member

(I just wanted to say thank you @tpounds for persisting with this!)

@tpounds
Copy link
Contributor Author

tpounds commented Dec 31, 2015

@justinsb No problem!

@ghost
Copy link

ghost commented Jan 1, 2016

@k8s-bot unit test this

@ghost
Copy link

ghost commented Jan 4, 2016

Same old unit test flakes, being tracked elsewhere. Try again.

@k8s-bot unit test this

==================
WARNING: DATA RACE
Write by goroutine 72:
  sync.raceWrite()
      /tmp/workdir/go/src/sync/race.go:41 +0x2e
  sync.(*WaitGroup).Wait()
      /tmp/workdir/go/src/sync/waitgroup.go:124 +0xf9
  net/http/httptest.(*Server).Close()
      /tmp/workdir/go/src/net/http/httptest/server.go:168 +0x80
  k8s.io/kubernetes/pkg/storage/etcd/testing.(*EtcdTestServer).Terminate()
      /workspace/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/storage/etcd/testing/utils.go:151 +0x138
  k8s.io/kubernetes/pkg/registry/generic/etcd.TestEtcdDeleteCollectionWithWatch()
      /workspace/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/registry/generic/etcd/etcd_test.go:558 +0x97a
  testing.tRunner()
      /tmp/workdir/go/src/testing/testing.go:456 +0xdc

Previous read by goroutine 74:
  sync.raceRead()
      /tmp/workdir/go/src/sync/race.go:37 +0x2e
  sync.(*WaitGroup).Add()
      /tmp/workdir/go/src/sync/waitgroup.go:66 +0xfa
  net/http/httptest.(*waitGroupHandler).ServeHTTP()
      /tmp/workdir/go/src/net/http/httptest/server.go:198 +0x5c
  net/http.serverHandler.ServeHTTP()
      /tmp/workdir/go/src/net/http/server.go:1862 +0x206
  net/http.(*conn).serve()
      /tmp/workdir/go/src/net/http/server.go:1361 +0x117c

Goroutine 72 (running) created at:
  testing.RunTests()
      /tmp/workdir/go/src/testing/testing.go:561 +0xaa3
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:494 +0xe4
  main.main()
      k8s.io/kubernetes/pkg/registry/generic/etcd/_test/_testmain.go:72 +0x20f

Goroutine 74 (running) created at:
  net/http.(*Server).Serve()
      /tmp/workdir/go/src/net/http/server.go:1910 +0x464
==================
--- PASS: TestEtcdDeleteCollectionWithWatch (0.17s)
=== RUN   TestEtcdWatch
==================
WARNING: DATA RACE
Write by goroutine 53:
  sync.raceWrite()
      /tmp/workdir/go/src/sync/race.go:41 +0x2e
  sync.(*WaitGroup).Wait()
      /tmp/workdir/go/src/sync/waitgroup.go:124 +0xf9
  net/http/httptest.(*Server).Close()
      /tmp/workdir/go/src/net/http/httptest/server.go:168 +0x80
  k8s.io/kubernetes/pkg/storage/etcd/testing.(*EtcdTestServer).Terminate()
      /workspace/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/storage/etcd/testing/utils.go:151 +0x138
  k8s.io/kubernetes/pkg/registry/generic/etcd.TestEtcdWatch()
      /workspace/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/registry/generic/etcd/etcd_test.go:612 +0xb5f
  testing.tRunner()
      /tmp/workdir/go/src/testing/testing.go:456 +0xdc

Previous read by goroutine 114:
  sync.raceRead()
      /tmp/workdir/go/src/sync/race.go:37 +0x2e
  sync.(*WaitGroup).Add()
      /tmp/workdir/go/src/sync/waitgroup.go:66 +0xfa
  net/http/httptest.(*waitGroupHandler).ServeHTTP()
      /tmp/workdir/go/src/net/http/httptest/server.go:198 +0x5c
  net/http.serverHandler.ServeHTTP()
      /tmp/workdir/go/src/net/http/server.go:1862 +0x206
  net/http.(*conn).serve()
      /tmp/workdir/go/src/net/http/server.go:1361 +0x117c

Goroutine 53 (running) created at:
  testing.RunTests()
      /tmp/workdir/go/src/testing/testing.go:561 +0xaa3
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:494 +0xe4
  main.main()
      k8s.io/kubernetes/pkg/registry/generic/etcd/_test/_testmain.go:72 +0x20f

Goroutine 114 (running) created at:
  net/http.(*Server).Serve()
      /tmp/workdir/go/src/net/http/server.go:1910 +0x464
==================
--- PASS: TestEtcdWatch (0.32s)
PASS
Found 2 data race(s)
FAIL    k8s.io/kubernetes/pkg/registry/generic/etcd 3.080s

@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2016
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Jan 4, 2016

GCE e2e test build/test passed for commit f2e43b04ebdbae93dd75012dc85a963c38cb7ca9.

@tpounds
Copy link
Contributor Author

tpounds commented Jan 5, 2016

@quinton-hoole I've rebased again to pick up flake test fixes.

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2016
@ghost ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 5, 2016

GCE e2e test build/test passed for commit bbc181d.

@ghost
Copy link

ghost commented Jan 5, 2016

@k8s-bot unit test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Jan 5, 2016

GCE e2e build/test failed for commit bbc181d.

@ghost
Copy link

ghost commented Jan 5, 2016

Good gracious, this is like giving birth to barbed wire.
The e2e test that failed is clearly flaky, as it's failed 2 out of 7 of it's most recent runs.
http://kubekins.dls.corp.google.com:8081/job/kubernetes-pull-build-test-e2e-gce/22451/testReport/junit/(root)/Kubernetes%20e2e%20suite/Deployment_deployment_should_support_rollover/history/
Besides that, all of the changes in this PR are not exercised by any of our e2e tests which run on GCE, not AWS. I'm going to merge this PR manually before it drives us all mad.

ghost pushed a commit that referenced this pull request Jan 5, 2016
@ghost ghost merged commit e663dbc into kubernetes:master Jan 5, 2016
@therc
Copy link
Member

therc commented Jan 6, 2016

So how do we get 1.0.7 now? :-) I tried, but I'm stuck in godep hell (camlistore has recently deleted pkg/errorutil and godep doesn't fetch the version that was pinned in Godeps.json).

@tpounds
Copy link
Contributor Author

tpounds commented Jan 6, 2016

@therc Do you have an open PR to upgrade the SDK to v1.0.7? If not, I can take a look a bit later today to see what it will take to upgrade to the latest version.

@therc
Copy link
Member

therc commented Jan 6, 2016

I think I might have figured it ten seconds ago. I'll file a PR in a few hours.

@therc
Copy link
Member

therc commented Jan 6, 2016

@tpounds It's #19351

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants