Remove periodSeconds, unavailable in 1.1 #18257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zmerlynn can I put this directly into 1.1, since HEAD onwards can still use the field? I can make the corresponding change in HEAD and cherry pick if you prefer (or just revert the previous cherry-pick, tests should pass since we had 2 greens inbetween). |
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
@k8s-bot unit test this please |
|
GCE e2e build/test failed for commit f4ce3d2. |
|
@k8s-bot test this please |
|
e2e failure looked unrelated |
|
GCE e2e test build/test passed for commit f4ce3d2. |
|
@k8s-bot unit test this please |
|
LGTM |
zmerlynn
added
the
lgtm
|
Green, merging. |
zmerlynn
added a commit
that referenced
this pull request
Dec 6, 2015
Remove periodSeconds, unavailable in 1.1
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
Remove periodSeconds, unavailable in 1.1
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
Remove periodSeconds, unavailable in 1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't realize "periodSeconds" is from: 1e88a68, which is not in 1.1. So currently the gke-e2e cluster doesn't even start the loadbalancer controller.