-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemd example unit and environment files #1831
Conversation
Can you add a README.md here? Over time I'd love to merge this with the large set of copy/pasted systemd configs being used for CoreOS. It'll help as we add new features like fluentd. |
946a139
to
4ac08b5
Compare
@jbeda README.md included. Should make it easier for people to give comments about what I'm doing. I believe it is flexible enough to everyone should be able to put down their own config/environment files and at least the .service files can be shared across everyone's example implementations... |
KUBE_MASTER="--master=127.0.0.1:8080" | ||
|
||
# Comma seperated list of minions | ||
MINION_ADDRESSES="--machines=127.0.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this works by default. I think that this is used as the address to get to the proxy. But when running in a container, 127.0.0.1 will go to the localhost in the container and not the proxy.
@thockin is this still relevant in the new IP-per-service world?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it - these are flags for apiserver, right? apiserver is not in a container (yet) is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we populate the service env variable for a container (in GetServiceEnvironmentVariables) we were using the IP address/name of the minion as far as the api server knew it. If the "name" of the minion that the apiserver sees is 127.0.0.1
then we would use that value to try and point the code int he container at the proxy. But it couldn't get to the proxy as the 127.0.0.1
inside the container would mask the 127.0.0.1
of the host. I suspect now that we have IP-per-Service this issue no longer applies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. In that case it won't matter. SERVICE_HOST is dead.
-portal-net added. I picked a default of 10.254.0.0/16 and noted it in the README |
Awesome! Great to see a standard set of files we can build on. Merging. |
systemd example unit and environment files
OCPBUGS-25814: Fix device uncertain errors on reboot - 4.13
The binary names in these are
kube-apiserver
kube-controller-manager
kube-scheduler
kube-proxy
kubelet
The environment/config files need to live in /etc/kubernetes/
I personally like the namespaced binaries a lot more than just 'apiserver' etc. I wouldn't mind if we switched the binary names to something namespaced in the in project build...