New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set User-Agent for HTTP prober requests. #18482

Closed

rochacon wants to merge 1 commit into kubernetes:master from rochacon:http-prober-user-agent

rochacon commented Dec 10, 2015

This change adds an User-Agent to HTTP prober, with the following format: Kubernetes/<version> HTTP-Prober.

This is useful to differentiate requests made by Kubernetes HTTP prober from other Go programs using the default Go HTTP client.

It's my first time playing with Kubernetes source, so I'm trying to keep this as simple as possible.


          Set User-Agent for HTTP prober requests.

5be24e1

Signed-off-by: Rodrigo Chacon <rochacon@gmail.com>

googlebot added the cla: yes label

k8s-bot commented Dec 10, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-github-robot commented Dec 10, 2015

Labelling this PR as size/M

k8s-github-robot assigned eparis

k8s-github-robot added the size/M label

k8s-bot commented Dec 10, 2015

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

3 similar comments

k8s-bot commented Jan 28, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot commented Jan 28, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-bot commented Feb 4, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

k8s-github-robot commented Feb 5, 2016

PR needs rebase

k8s-github-robot added the needs-rebase label

bgrant0607 assigned liggitt and unassigned eparis

Member

liggitt commented Feb 20, 2016

https://github.com/kubernetes/kubernetes/pull/20116/files#diff-ca8ccba349ee7f2f0cddbb8305fc86a1 added the ability to specify headers for probes. I think I prefer letting the user setting up the probe determine the user-agent (if any), which they can now do via the API. What do you think?

Author

rochacon commented Feb 23, 2016

Hi @liggitt, setting custom headers on probes is really cool. I would like a default, but overwritable, User-Agent though, to avoid the need to set this header on every controller.
Considering this would be a completely different PR, I'm closing this one.

Thanks for the update!

rochacon closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment