Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake a test - Sleep(5) != 5 seconds #18674

Merged
merged 1 commit into from
Dec 15, 2015

Conversation

thockin
Copy link
Member

@thockin thockin commented Dec 14, 2015

Fixes #18283 (I hope - very rare flake)

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 14, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 14, 2015

GCE e2e test build/test passed for commit 86b91ac.

@wojtek-t wojtek-t assigned wojtek-t and unassigned ixdy Dec 15, 2015
@wojtek-t
Copy link
Member

Great catch - thanks @thockin

LGTM

@wojtek-t wojtek-t added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Dec 15, 2015
@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 15, 2015
@k8s-github-robot k8s-github-robot merged commit 430be9f into kubernetes:master Dec 15, 2015
@thockin thockin deleted the e2e-service-flakes branch January 4, 2016 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants