Podex handling multiple images #1898
Conversation
| @@ -40,10 +40,11 @@ import ( | |||
| "gopkg.in/v1/yaml" | |||
| ) | |||
|
|
|||
| const usage = "usage: podex [-json|-yaml] <repo/dockerimage>" | |||
| const usage = "usage: podex [-json|-yaml] -podID=ID <repo/dockerimage1> ... <repo/dockerimageN>" | |||
There was a problem hiding this comment.
what about -id should be obvious since the output is a pod configuration..
|
Just some nits, thanks a lot for doing this :) |
|
@proppy thanks for review. Updated and rebased the PR :) |
| if *podName == "" { | ||
| if flag.NArg() > 1 { | ||
| log.Fatal(usage) | ||
| } else { |
There was a problem hiding this comment.
you can remove the else, since the log is fatal.
There was a problem hiding this comment.
yep, sorry for that
jhadvig
force-pushed
the
podex_images
branch
3 times, most recently
from
9ded97a
to
4f5331e
Compare
|
@proppy rebased, sorry for that :) |
| @@ -120,3 +128,14 @@ func main() { | |||
| os.Stdout.Write(bs) | |||
| } | |||
| } | |||
|
|
|||
| // Function takes images name which is parsed. | |||
There was a problem hiding this comment.
parseDockerImage split a docker image name of the form
[REGISTRYHOST/][USERNAME/]NAME[:TAG]
We should probably add a TODO to handle the TAG
| @@ -40,10 +40,11 @@ import ( | |||
| "gopkg.in/v1/yaml" | |||
| ) | |||
|
|
|||
| const usage = "usage: podex [-json|-yaml] <repo/dockerimage>" | |||
| const usage = "usage: podex [-json|-yaml] -id=ID <repo/dockerimage1> ... <repo/dockerimageN>" | |||
There was a problem hiding this comment.
I think this should be: username/image1 username/image2, I think repo refers to username/image
|
LGTM just some docstring nits |
|
@proppy rebased |
|
Merged thanks. |
[release-4.14] OCPBUGS-29924: UPSTREAM: <carry>: openshift-kube-apiserver: add kube-apiserver patches
Podex can now handle multiple images.
Also adding
podIDflag, with which user can specify the pod ID.eg:
podex -json -podID=nodejs dockerfile/redis google/nodejs-helloIn case the command will take only one image the
podIDis optional and image base-name will be used for as a podID