Fix master_test flake #19195
Fix master_test flake #19195
Conversation
|
Labelling this PR as size/M |
k8s-github-robot
added
the
size/M
wojtek-t
force-pushed
the
fix_master_test
branch
from
33fe6b2
to
a0794a8
Compare
|
GCE e2e test build/test passed for commit 33fe6b2dd778a1d9dbefba04e709e682a830e091. |
|
GCE e2e test build/test passed for commit a0794a8ea53cbdfff912ed88d1df91833bcda130. |
| @@ -150,7 +168,12 @@ func NewEtcdTestClientServer(t *testing.T) *EtcdTestServer { | |||
| } | |||
| server.Client, err = etcd.New(cfg) | |||
| if err != nil { | |||
| t.Errorf("Unexpected Error in NewEtcdTestClientServer (%v)", err) | |||
| t.Errorf("Unexpected error in NewEtcdTestClientServer (%v)", err) | |||
| defer server.Terminate(t) | |||
There was a problem hiding this comment.
What's the reason for defer here? Will terminating server before returning cause some races?
There was a problem hiding this comment.
consistency with what was before (6 lines below)
There was a problem hiding this comment.
Yeah - maybe we should remove it from both those places then?
wojtek-t
force-pushed
the
fix_master_test
branch
from
a0794a8
to
9ada897
Compare
|
@gmarek - PTAL |
gmarek
added
the
lgtm
|
e2e is not requires as this only touches unit tests, but we need to wait for unit/integration tests to finish before applying the label... |
|
GCE e2e build/test failed for commit 9ada897. |
|
GCE e2e test build/test passed for commit 9ada897. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
@k8s-bot unit test this please |
|
GCE e2e test build/test passed for commit 9ada897. |
|
@k8s-bot unit test this please |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Fix #19141