Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "201" walkthrough. #1924

Merged
merged 1 commit into from
Oct 21, 2014
Merged

Conversation

brendandburns
Copy link
Contributor

No description provided.

kind: ReplicationController
desiredState:
replicas: 2
replicaSelector:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worthwhile to put some comments in this YAML about how the replicaSelector relates to the labels on the pod that is created. Not sure how far we want to go into annotating this example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@jbeda
Copy link
Contributor

jbeda commented Oct 21, 2014

Very cool! We should probably do a set of screencasts at some point that go through this stuff so that folks can see it in action.

LGTM when you are ready to merge.

@brendandburns
Copy link
Contributor Author

Thanks for the comments. Addressed and merging.

brendandburns added a commit that referenced this pull request Oct 21, 2014
@brendandburns brendandburns merged commit 0714de2 into kubernetes:master Oct 21, 2014
p0lyn0mial pushed a commit to p0lyn0mial/kubernetes that referenced this pull request Apr 3, 2024
OCPBUGS-31384: UPSTREAM: <carry>: allow type mutation for specific secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants