Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #19350 upstream release 1.1 #19420

Merged
merged 1 commit into from
Jan 8, 2016
Merged

Automated cherry pick of #19350 upstream release 1.1 #19420

merged 1 commit into from
Jan 8, 2016

Conversation

ikehz
Copy link
Contributor

@ikehz ikehz commented Jan 8, 2016

Automated cherry pick of #19350 upstream release-1.1.

Improve error reporting a little in ingress e2e. Also add Output() to the util/exec Cmd interface.

We'd like to get this into v1.1.4, but it's not completely crucial because it's just a test fix.

This was a messy cherry pick, please review with skepticism.

@ikehz ikehz added area/test priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. team/cluster labels Jan 8, 2016
@brendandburns
Copy link
Contributor

LGTM. thanks ike

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 8, 2016
@ikehz
Copy link
Contributor Author

ikehz commented Jan 8, 2016

Fixes #19394.

@k8s-bot
Copy link

k8s-bot commented Jan 8, 2016

GCE e2e build/test failed for commit fbdc2f3.

@ikehz
Copy link
Contributor Author

ikehz commented Jan 8, 2016

@k8s-bot test this again

@k8s-bot
Copy link

k8s-bot commented Jan 8, 2016

GCE e2e build/test failed for commit fbdc2f3.

@ikehz
Copy link
Contributor Author

ikehz commented Jan 8, 2016

Known flake (#19180). Merging to get into v1.1.4. (cc @k8s-oncall)

ikehz pushed a commit that referenced this pull request Jan 8, 2016
…9350-upstream-release-1.1

Automated cherry pick of #19350 upstream release 1.1
@ikehz ikehz merged commit 2337f20 into kubernetes:release-1.1 Jan 8, 2016
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…pick-of-#19350-upstream-release-1.1

Automated cherry pick of kubernetes#19350 upstream release 1.1
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…pick-of-#19350-upstream-release-1.1

Automated cherry pick of kubernetes#19350 upstream release 1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants