Add requirements based scheduling. #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandburns
force-pushed
the
scheduler
branch
from
1e1127e
to
2f3e5a2
Compare
| @@ -367,6 +367,8 @@ type Pod struct { | |||
| Labels map[string]string `json:"labels,omitempty" yaml:"labels,omitempty"` | |||
| DesiredState PodState `json:"desiredState,omitempty" yaml:"desiredState,omitempty"` | |||
| CurrentState PodState `json:"currentState,omitempty" yaml:"currentState,omitempty"` | |||
| // NodeSelector is a selector which must be true for the pod to fit on a node | |||
| NodeSelector map[string]string `json:"nodeSelector,omitempty" yaml:"nodeSelector,omitempty"` | |||
There was a problem hiding this comment.
What are you going to use this selector to accomplish? @erictune and I were talking about something similar based on the presence of a trust relationship in the auth stuff.
There was a problem hiding this comment.
Look at the changes to predicates. This is so that we can do constraint/requirements based scheduling.
|
Is there a reason why you aren't adding this to the default predicate list? |
brendandburns
force-pushed
the
scheduler
branch
from
2f3e5a2
to
58a2e37
Compare
|
I'd rather submit the predicate first, and then activate it in a different PR. That way if it breaks, it's easier to just rollback the activation, rather than the entire PR. Other comment addressed. Please re-check. Thanks! |
|
LGTM |
brendandburns
force-pushed
the
scheduler
branch
from
58a2e37
to
fb40ae2
Compare
brendandburns
force-pushed
the
scheduler
branch
from
fb40ae2
to
5d4d607
Compare
bgrant0607
added a commit
that referenced
this pull request
Oct 27, 2014
Add requirements based scheduling.
bgrant0607
added
the
sig/scheduling
bertinatto
pushed a commit
to bertinatto/kubernetes
that referenced
this pull request
May 15, 2024
OCPBUGS-32299: Bump to k8s 1.28.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds scheduling constraints. See #367 for more details.