Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MetricsForE2E public #19532

Merged
merged 1 commit into from
Jan 12, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/framework.go
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ func (f *Framework) afterEach() {
if err != nil {
Logf("MetricsGrabber failed grab metrics. Skipping metrics gathering.")
} else {
summaries = append(summaries, (*metricsForE2E)(&received))
summaries = append(summaries, (*MetricsForE2E)(&received))
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions test/e2e/metrics_util.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ const (
apiCallLatencyLargeThreshold time.Duration = 1 * time.Second
)

type metricsForE2E metrics.MetricsCollection
type MetricsForE2E metrics.MetricsCollection

func (m *metricsForE2E) PrintHumanReadable() string {
func (m *MetricsForE2E) PrintHumanReadable() string {
buf := bytes.Buffer{}
for _, interestingMetric := range InterestingApiServerMetrics {
buf.WriteString(fmt.Sprintf("For %v:\n", interestingMetric))
Expand All @@ -69,7 +69,7 @@ func (m *metricsForE2E) PrintHumanReadable() string {
return buf.String()
}

func (m *metricsForE2E) PrintJSON() string {
func (m *MetricsForE2E) PrintJSON() string {
return prettyPrintJSON(*m)
}

Expand Down