Export variables needed by e2e-runner.sh in the release-1.1 branch. #19545
Conversation
|
Labelling this PR as size/S |
k8s-github-robot
added
the
size/S
|
GCE e2e test build/test passed for commit f8c4090cb6dd6e7ad3d3511f12a37ca7c6bdfbb0. |
|
GCE e2e test build/test passed for commit 39c743d1414d8586709a1de234a035e6711a9764. |
| @@ -964,12 +966,18 @@ export PATH=${PATH}:/usr/local/go/bin | |||
| export KUBE_SKIP_UPDATE=y | |||
| export KUBE_SKIP_CONFIRMATIONS=y | |||
|
|
|||
| # Kubemark | |||
| export USE_KUBEMARK="${USE_KUBEMARK:-false}" | |||
There was a problem hiding this comment.
Kubemark only exists on master right now, right?
This makes me realize that this practice isn't fully sustainable - if we add more config vars in the future (likely), we shouldn't have to backport default values for those to each of the release branches.
|
@ixdy Agreed. I guess it's okay to leave them with their defaults for now. In the future I'd like to rework e2e-runner.sh, but this should do for now. PTAL. |
|
Labelling this PR as size/XS |
k8s-github-robot
added
size/XS
|
GCE e2e test build/test passed for commit 9005252. |
|
LGTM @k8s-bot test this please |
|
why is the "close and comment" button so large? :( |
ixdy
added
the
lgtm
|
GCE e2e test build/test passed for commit 9005252. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 9005252. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
Auto commit by PR queue bot
Auto commit by PR queue bot
UPSTREAM: 63160: kubelet: logs: do not wait when following terminated container Origin-commit: 8c865bbd7782674dfc1a473a4c54b8354fe05f7c
#19419
I also turned off xtrace as I did previously for e2e.sh in master.