Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leaderelection: retrofit controller-manager with leaderelection client #19621

Merged
merged 1 commit into from Jan 20, 2016
Merged

leaderelection: retrofit controller-manager with leaderelection client #19621

merged 1 commit into from Jan 20, 2016

Conversation

mikedanese
Copy link
Member

No description provided.

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 13, 2016
@mikedanese mikedanese assigned davidopp and unassigned thockin Jan 13, 2016
davidopp
davidopp reviewed Jan 14, 2016
View reviewed changes
docs/admin/kube-controller-manager.md
@@ -74,6 +74,10 @@ kube-controller-manager
--kube-api-burst=30: Burst to use while talking with kubernetes apiserver
--kube-api-qps=20: QPS to use while talking with kubernetes apiserver
--kubeconfig="": Path to kubeconfig file with authorization and master location information.
--leader-elect[=false]: Start a leader election client and gain leadership before executing scheduler loop. Enable this when running replicated schedulers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/scheduler/controller manager/
s/schedulers/controller managers/

@mikedanese
Copy link
Member Author

@davidopp fixed

@k8s-bot
Copy link

k8s-bot commented Jan 14, 2016

GCE e2e test build/test passed for commit 07042ef272f66dcfa0d0a76a32d71c227fadf59d.

@mikedanese
Copy link
Member Author

@k8s-bot unit test this please

davidopp
davidopp reviewed Jan 14, 2016
View reviewed changes
docs/admin/kube-controller-manager.md
@@ -74,6 +74,10 @@ kube-controller-manager
--kube-api-burst=30: Burst to use while talking with kubernetes apiserver
--kube-api-qps=20: QPS to use while talking with kubernetes apiserver
--kubeconfig="": Path to kubeconfig file with authorization and master location information.
--leader-elect[=false]: Start a leader election client and gain leadership before executing scheduler loop. Enable this when running replicated components for high availability.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still says scheduler

@mikedanese mikedanese force-pushed the retrofit-controller-manager branch 2 times, most recently from 352e55e to 7ad7350 Compare January 14, 2016 18:36
@k8s-bot
Copy link

k8s-bot commented Jan 14, 2016

GCE e2e test build/test passed for commit 7ad735012f91644d7f4a032c13eb435d883df398.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 15, 2016

GCE e2e test build/test passed for commit dd394ddd8a69844f1264993c607942e1d4460d06.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2016
@davidopp davidopp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2016
@davidopp
Copy link
Member

LGTM but needs rebase.

@k8s-github-robot
Copy link

PR changed after LGTM, removing LGTM.

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 18, 2016
@mikedanese
leaderelection: retrofit controller-manager with leaderelection client
a885d84 
Signed-off-by: Mike Danese <mikedanese@google.com>
@k8s-bot
Copy link

k8s-bot commented Jan 18, 2016

GCE e2e test build/test passed for commit 77c0dd9bfbfc9e22a06e70f6b100365d14a4760d.

@k8s-bot
Copy link

k8s-bot commented Jan 18, 2016

GCE e2e test build/test passed for commit a885d84.

@davidopp davidopp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2016
@davidopp
Copy link
Member

@k8s-bot test this please

@k8s-bot
Copy link

k8s-bot commented Jan 18, 2016

GCE e2e test build/test passed for commit a885d84.

@k8s-bot
Copy link

k8s-bot commented Jan 18, 2016

GCE e2e test build/test passed for commit a885d84.

@mikedanese
Copy link
Member Author

@k8s-bot unit test this please. Integration test flake:

15:36:38 F0118 23:36:38.687266    1319 controller.go:84] Unable to perform initial IP allocation check: unable to persist the updated service IP allocations: serviceipallocations "" cannot be updated: the provided resource version does not match
15:38:40 !!! [0118 23:38:40] Timed out waiting for apiserver:  to answer at http://127.0.0.1:8080/healthz; tried 120 waiting 1 between each
15:38:40 !!! Error in ./hack/test-update-storage-objects.sh:48

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Jan 20, 2016
Merge pull request #19621 from mikedanese/retrofit-controller-manager
864065b 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 864065b into kubernetes:master Jan 20, 2016
@mikedanese mikedanese deleted the retrofit-controller-manager branch January 20, 2016 01:30
This was referenced Feb 3, 2016
Closed
Open
@jiahuif jiahuif mentioned this pull request Mar 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mikedanese @k8s-github-robot @k8s-bot @davidopp @k8s-teamcity-mesosphere @googlebot @thockin