Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FitError: return details of failure on each node #19906

Merged
merged 1 commit into from
Jan 26, 2016
Merged

FitError: return details of failure on each node #19906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 7 additions & 8 deletions plugin/pkg/scheduler/generic_scheduler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ limitations under the License.
package scheduler

import (
"bytes"
"fmt"
"math/rand"
"sort"
Expand All @@ -41,17 +42,15 @@ type FitError struct {

var ErrNoNodesAvailable = fmt.Errorf("no nodes available to schedule pods")

// implementation of the error interface
// Error returns detailed information of why the pod failed to fit on each node
func (f *FitError) Error() string {
var reason string
// We iterate over all nodes for logging purposes, even though we only return one reason from one node
var buf bytes.Buffer
buf.WriteString(fmt.Sprintf("pod (%s) failed to fit in any node\n", f.Pod.Name))
for node, predicateList := range f.FailedPredicates {
glog.V(2).Infof("Failed to find fit for pod %v on node %s: %s", f.Pod.Name, node, strings.Join(predicateList.List(), ","))
if len(reason) == 0 {
reason, _ = predicateList.PopAny()
}
reason := fmt.Sprintf("fit failure on node (%s): %s\n", node, strings.Join(predicateList.List(), ","))
buf.WriteString(reason)
}
return fmt.Sprintf("Failed for reason %s and possibly others", reason)
return buf.String()
}

type genericScheduler struct {
Expand Down