A Docker image for Kibana designed to work with Kubernetes logging #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satnam6502
force-pushed
the
kibana-image
branch
4 times, most recently
from
8077c10
to
4ef9477
Compare
| # http://$ELASTICSEARCH_SERVICE_HOST:$ELASTICSEARCH_SERVICE_PORT:9200/XXX | ||
| # The proxy configuration occurs in a location block of the nginx configuration | ||
| # file /etc/nginx/sites-available/default. | ||
|
|
There was a problem hiding this comment.
Start the script with the following to ensure uncaught errors will break the script:
set -o errexit
set -o nounset
set -o pipefail
|
Some nitpicks but otherwise looks good. |
satnam6502
force-pushed
the
kibana-image
branch
2 times, most recently
from
7d20317
to
f568e20
Compare
satnam6502
force-pushed
the
kibana-image
branch
from
f568e20
to
ceced23
Compare
|
Thank you kindly @filbranden for your help. I think I have implemented all of your excellent suggestions. |
filbranden
added a commit
that referenced
this pull request
Oct 28, 2014
A Docker image for Kibana designed to work with Kubernetes logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the source for a special Kibana Docker image which is set up to work with Elasticsearch and Kibana in separate pods or in the same pod.