Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FSGroup e2es [Feature:FSGroup], not [Skipped] #20183

Merged
merged 1 commit into from
Feb 9, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/downwardapi_volume.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ var _ = Describe("Downward API volume", func() {
}, f.Namespace.Name)
})

It("should provide podname as non-root with fsgroup [Conformance] [Skipped]", func() {
It("should provide podname as non-root with fsgroup [Feature:FSGroup]", func() {
podName := "metadata-volume-" + string(util.NewUUID())
uid := int64(1001)
gid := int64(1234)
Expand Down
11 changes: 5 additions & 6 deletions test/e2e/empty_dir.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,21 +37,20 @@ var _ = Describe("EmptyDir volumes", func() {

f := NewFramework("emptydir")

// TODO: Remove [Skipped] when security context is enabled everywhere
Context("when FSGroup is specified [Skipped]", func() {
It("new files should be created with FSGroup ownership when container is root [Conformance]", func() {
Context("when FSGroup is specified [Feature:FSGroup]", func() {
It("new files should be created with FSGroup ownership when container is root", func() {
doTestSetgidFSGroup(f, testImageRootUid, api.StorageMediumMemory)
})

It("new files should be created with FSGroup ownership when container is non-root [Conformance]", func() {
It("new files should be created with FSGroup ownership when container is non-root", func() {
doTestSetgidFSGroup(f, testImageNonRootUid, api.StorageMediumMemory)
})

It("volume on default medium should have the correct mode using FSGroup [Conformance]", func() {
It("volume on default medium should have the correct mode using FSGroup", func() {
doTestVolumeModeFSGroup(f, testImageRootUid, api.StorageMediumDefault)
})

It("volume on tmpfs should have the correct mode using FSGroup [Conformance]", func() {
It("volume on tmpfs should have the correct mode using FSGroup", func() {
doTestVolumeModeFSGroup(f, testImageRootUid, api.StorageMediumMemory)
})
})
Expand Down