Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #19431 #20283

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jan 28, 2016

Cherry pick of #19431 on release-1.1.

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 28, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 28, 2016

GCE e2e test build/test passed for commit 976360a.

@ikehz
Copy link
Contributor

ikehz commented Jan 28, 2016

Seems reasonable to me, but why does this need to be in v1.1? Can it wait until v1.2?

@spiffxp
Copy link
Member Author

spiffxp commented Jan 28, 2016

Scratching an itch, trying to build release-1.1 tests and master tests and compare their performance. Thinking I either start moving to the "pull scripts from master" approach or keep cherry-picking around. Is there a better way of doing this I'm missing?

@ikehz
Copy link
Contributor

ikehz commented Jan 28, 2016

No, I suppose that's fine. Just wanted justification, mostly for posterity. 👍 LGTM.

@ikehz ikehz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2016
ikehz pushed a commit that referenced this pull request Jan 28, 2016
…1-upstream-release-1.1

Automated cherry pick of #19431
@ikehz ikehz merged commit e7efae3 into kubernetes:release-1.1 Jan 28, 2016
@spiffxp spiffxp deleted the automated-cherry-pick-of-#19431-upstream-release-1.1 branch January 28, 2016 21:20
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…k-of-#19431-upstream-release-1.1

Automated cherry pick of kubernetes#19431
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…k-of-#19431-upstream-release-1.1

Automated cherry pick of kubernetes#19431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants