Automated cherry pick of #15475 #20534
Conversation
update update mode delete /tmp update use ioutil.TempDir instead of static tmp dir use ioutil.TempDir instead of static tmp dir
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
For #20503 |
|
@jijun2 askin on googlebots behest (#20534 (comment)), are you ok with cherrypicking your unittest fix to the 1.1 branch? |
|
Should probably cherry-pick #20111 too. |
|
Labelling this PR as size/L |
k8s-github-robot
added
the
size/L
|
@ixdy that doesn't rebase cleanly. Can i get this one and send a follow up pr for that? (since I expect using hardcoded paths to be the main source of flake) |
|
GCE e2e build/test failed for commit 7447d8d. |
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
Should we cherry-pick this to 1.1? @ihmccreery @jlowdermilk |
|
If it will fix cni_test flakes we've seen on the 1.1 branch, I'd say it's worth cherrypicking. Changes are all test code, so should be very low risk. |
|
@k8s-bot ok to test |
|
GCE e2e build/test failed for commit 7447d8d. |
|
GCE e2e test build/test passed for commit 7447d8d. |
ixdy
added
lgtm
|
LGTM |
|
How do we handle the cla complaint? I cc'd original author @jijun2 in #20534 (comment) but I think he's unavailable. Safe to ignore? |
|
So just hand merge? since sq won't pick it up |
|
SQ should pick this up eventually. |
|
ah, cla:human-approved. Missed that. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 7447d8d. |
|
Automatic merge from submit-queue |
…5475-upstream-release-1.1 Auto commit by PR queue bot
…pick-of-#15475-upstream-release-1.1 Auto commit by PR queue bot
…pick-of-#15475-upstream-release-1.1 Auto commit by PR queue bot
Cherry pick of #15475 on release-1.1.