Update guestbook frontend php script as suggested in issue #18640. #21327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
LGTM |
|
cc @carlosrdrz |
|
It would be useful for someone with a non-privileged account to confirm that they can pull the new image. |
|
GCE e2e test build/test passed for commit 2d8f857. |
|
Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist") If this message is too spammy, please complain to ixdy. |
|
@bgrant0607 Brian, I got Takashi, who is not on the google-samples project, to do a test pull of gcr.io/google-samples/gb-frontend:v4, and he was successful. |
|
Thanks, @amygdala. LGTM |
bgrant0607
added
the
lgtm
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Feb 17, 2016
Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update guestbook frontend php script as suggested in issue #18640.
(also created new GCR image version with the changes).