Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP/MESOS: handle slave-lost and REASON_SLAVE_REMOVED events #21366

Closed
wants to merge 12 commits into from
Closed

WIP/MESOS: handle slave-lost and REASON_SLAVE_REMOVED events #21366

wants to merge 12 commits into from

Conversation

jdef
Copy link
Contributor

@jdef jdef commented Feb 17, 2016 •
edited by k8s-github-robot

@jdef jdef self-assigned this Feb 17, 2016
@jdef jdef mentioned this pull request Feb 17, 2016
Open
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2016
jdef
jdef reviewed Feb 18, 2016
View reviewed changes
contrib/mesos/pkg/executor/service/kubelet.go
@@ -17,10 +17,10 @@ limitations under the License.
package service

import (
log "github.com/golang/glog"
// log "github.com/golang/glog"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented package imports

@jdef
Copy link
Contributor Author

jdef commented Feb 18, 2016 

I0217 23:05:50.150130    6830 mirrors.go:159] garbage collecting pods on host "10.2.0.6" slave "26bd3125-53e1-4fa2-aada-eeffd5657a4a-S1"
I0217 23:05:50.152202    6830 mirrors.go:178] deleting pod default/busybox-10.2.0.6
E0217 23:05:50.155475    6830 deleter.go:58] No such pod exists

^^ why is deleter reporting static pods at all?

@jdef
Copy link
Contributor Author

jdef commented Feb 19, 2016

need changes from #21521 so that we can accurately garbage collect pods from apiserver that, due to racy termination conditions, are no longer updated by a kubelet - but aren't GC'd by k8s because k8sm is running a "special" node controller that keeps Ready status to true as long as the slave is running.

James DeFelice added 11 commits March 12, 2016 01:36
first pass at implementing cleanup when slave-lost message is receive…
d1ef7f3 
…d; still WIP
shorter default suicide timeout; static pod source should send blank …
fefaf18 
…snapshot once executor enters shutdown mode
remove dependency on kubelet finished, executor shutdown uses simple …
379a582 
…timeout to try providing time for docker container cleanup; fix bugs in scheduler pod gc
change log.Error to log.Info for state transition edge case in reregi…
1dd5e3f 
…stration
add node condition for running-executor
81d764c
fix broken unit test
2067590
refactored filtering interface
d5d47d8
add timestamped executor container UUID annotation to all pods
620108b
refactor StatusUpdater into a more general node controller scaffold w…
05f7486 
…/ functional options
update reason code for nodes with out of date conditions
bc2bf76
started implementation of a new controller
debd9bf
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 12, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 12, 2016

GCE e2e build/test passed for commit 2d04f31.

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2016
@k8s-github-robot
Copy link

@jdef PR needs rebase

@k8s-github-robot
Copy link

This PR hasn't been active in 129 days. Feel free to reopen.

You can add 'keep-open' label to prevent this from happening again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdef jdef

Labels
area/platform/mesos needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdef @k8s-bot @k8s-github-robot @k8s-teamcity-mesosphere @googlebot