Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Jobs to batch/v1 group #21434

Merged
merged 10 commits into from Feb 22, 2016
Merged

Conversation

erictune
Copy link
Member

No description provided.

@k8s-github-robot
Copy link

Labelling this PR as size/XXL

@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 17, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 17, 2016

GCE e2e build/test failed for commit c0f11744821c0aa8a9274706c42c363a35191fb2.

@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e build/test failed for commit 3f9faec39d818eb55323cbb2cb7bc45ec4aa617b.

@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e build/test failed for commit c5c4505bad0c2bd7acbb9d4e5a6b73a973f80d49.

@k8s-github-robot
Copy link

PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e build/test failed for commit 85e35612eb991eab7b0c69ada6732efad8afa25d.

@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e build/test failed for commit 794ca75154fba36be9eb9a23e0103d6e1d5c6ee2.

@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e build/test failed for commit 815afc99f4907d98183c3383d46143b37a4b947b.

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e test build/test passed for commit f40fa0c30793c376a2d183272565b72011e6e608.

@k8s-github-robot
Copy link

PR needs rebase

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2016
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 18, 2016
@erictune
Copy link
Member Author

@lavalamp this should be working well enough for you to take a look at it. I'm waiting to see what integration and e2e testing says, but unit tests pass.

@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e test build/test passed for commit 262f2859a9fd83f641eb819552c68536cd158071.

@k8s-bot
Copy link

k8s-bot commented Feb 18, 2016

GCE e2e build/test failed for commit a3b6e23f792547f2d2a25dca3b5bfaa73950d4d8.

@@ -35,7 +35,7 @@ TMP_ROOT="${KUBE_ROOT}/_tmp"

echo "diffing ${API_REFERENCE_DOCS_ROOT} against freshly generated docs"
ret=0
diff -NauprBZ -I 'Last update' --exclude=*.md "${API_REFERENCE_DOCS_ROOT}" "${OUTPUT_DIR}" || ret=$?
diff -NauprB -I 'Last update' --exclude=*.md "${API_REFERENCE_DOCS_ROOT}" "${OUTPUT_DIR}" || ret=$?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this diff intentional? seems unrelated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't regenerate on my machine without this. But I can take it out of this PR.

@lavalamp
Copy link
Member

No major comments.

@k8s-bot
Copy link

k8s-bot commented Feb 19, 2016

GCE e2e test build/test passed for commit 391a2986db0e315609c2604434f6055a20819b85.

@erictune
Copy link
Member Author

I intend the commit named "Comment out test to fix later" to merge.

@k8s-bot
Copy link

k8s-bot commented Feb 19, 2016

GCE e2e test build/test passed for commit da44473.

@k8s-bot
Copy link

k8s-bot commented Feb 19, 2016

GCE e2e test build/test passed for commit bb056195ed5fc37ed78e37147b62c6044a525c5d.

@k8s-bot
Copy link

k8s-bot commented Feb 19, 2016

GCE e2e test build/test passed for commit 55592c8363f011b190c463a7b3fb0f347e9b8d07.

@k8s-bot
Copy link

k8s-bot commented Feb 20, 2016

GCE e2e test build/test passed for commit 53e6b7f6bf0544389e8958140757f754ec76ebf6.

@k8s-bot
Copy link

k8s-bot commented Feb 20, 2016

GCE e2e test build/test passed for commit bab89e9.

@erictune
Copy link
Member Author

Applying LGTM that @lavalamp gave over chat.

@erictune erictune added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 21, 2016

GCE e2e build/test failed for commit bab89e9.

@erictune
Copy link
Member Author

@k8s-bot e2e test this issue #21463

@k8s-bot
Copy link

k8s-bot commented Feb 22, 2016

GCE e2e test build/test passed for commit bab89e9.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 22, 2016

GCE e2e build/test failed for commit bab89e9.

@erictune
Copy link
Member Author

@k8s-bot e2e test this issue #21463

@k8s-bot
Copy link

k8s-bot commented Feb 22, 2016

GCE e2e test build/test passed for commit bab89e9.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Feb 22, 2016

GCE e2e test build/test passed for commit bab89e9.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Feb 22, 2016
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit aee2eb3 into kubernetes:master Feb 22, 2016
@lavalamp
Copy link
Member

\o/

On Mon, Feb 22, 2016 at 12:13 AM, k8s-merge-robot notifications@github.com
wrote:

Automatic merge from submit-queue


Reply to this email directly or view it on GitHub
#21434 (comment)
.

openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this pull request Feb 23, 2019
 collapse onto upstream version command

Origin-commit: adedf5992edb55e371d68d4e41e83bbf8673c7c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants