-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Heapster as an in-built monitoring solution for Kubernetes in GCE. #2208
Conversation
|
||
Heapster enables monitoring of Kubernetes Clusters using [cAdvisor](https://github.com/google/cadvisor). It currently works only on GCE. | ||
|
||
#####Run Heapster in a Kubernetes cluster with an Influxdb backend and [Grafana](http://grafana.org/docs/features/influxdb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm I'm torn. I don't think we should include these instructions here (they are in the heapster repo and we can point people there). Maybe just have the ones for how to access heapster? Here we should probably put the instructions of how to make kube-up enable heapster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought users can choose to try it outside of kube-up too. I can just place a pointer to the heapster repo. Does that sound reasonable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds perfect
LGTM |
"containers": [{ | ||
"name": "influxdb", | ||
"image": "kubernetes/heapster_influxdb", | ||
"ports": [{"containerPort": 8083, "hostPort": 8083}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really need hostPort?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backend DB (InfluxDB) has its UI available at this port.
Are we sure we want to enable this by default? This means even e2e test will start Heapster service, which might potentially slow down the core service / cluster for testing. How about having a flag to enable / disable this? |
"apiVersion": "v1beta1", | ||
"port": 8085, | ||
"containerPort": 8086, | ||
"selector": { "name": "influxdb" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems overly generic.
"provider": "kubernetes-default",
"component": "influxdb"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the fields you mentioned. My Kube-fu is limited as of now.
Users will have an option to enable it when they setup their cluster (kube-up).
…sable it for tests. Updated heapster readme.
@dchen1107: As per your suggestion, I have added a config option for monitoring and disabled it for tests. |
LGTM. @vishh any thoughts about making an e2e test for this? |
Use Heapster as an in-built monitoring solution for Kubernetes in GCE.
Somehow I think this broke our e2e test?
|
Posted #2240 to fix that. On Fri, Nov 7, 2014 at 1:26 PM, Daniel Smith notifications@github.com
|
Users will have an option to enable it when they setup their cluster (kube-up).
cc @thockin @vmarmol @rjnagal