Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable node e2e readonly fs test #22215

Merged
merged 1 commit into from
Mar 1, 2016
Merged

enable node e2e readonly fs test #22215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
94 changes: 47 additions & 47 deletions test/e2e_node/kubelet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,53 +88,53 @@ var _ = Describe("Kubelet", func() {
})
})

// TODO: Enable this when issues are resolved. Tracked in #21320
// Context("when scheduling a read only busybox container", func() {
// It("it should return success", func() {
// pod := &api.Pod{
// ObjectMeta: api.ObjectMeta{
// Name: "busybox",
// Namespace: api.NamespaceDefault,
// },
// Spec: api.PodSpec{
// // Force the Pod to schedule to the node without a scheduler running
// NodeName: *nodeName,
// // Don't restart the Pod since it is expected to exit
// RestartPolicy: api.RestartPolicyNever,
// Containers: []api.Container{
// {
// Image: "gcr.io/google_containers/busybox",
// Name: "busybox",
// Command: []string{"sh", "-c", "echo test > /file"},
// SecurityContext: &api.SecurityContext{
// ReadOnlyRootFilesystem: &isReadOnly,
// },
// },
// },
// },
// }
// _, err := cl.Pods(api.NamespaceDefault).Create(pod)
// Expect(err).To(BeNil(), fmt.Sprintf("Error creating Pod %v", err))
// })
//
// It("it should not write to the root filesystem", func() {
// Eventually(func() string {
// rc, err := cl.Pods(api.NamespaceDefault).GetLogs("busybox", &api.PodLogOptions{}).Stream()
// if err != nil {
// return ""
// }
// defer rc.Close()
// buf := new(bytes.Buffer)
// buf.ReadFrom(rc)
// return buf.String()
// }, time.Second*30, time.Second*4).Should(Equal("sh: can't create /file: Read-only file system"))
// })
//
// It("it should be possible to delete", func() {
// err := cl.Pods(api.NamespaceDefault).Delete("busybox", &api.DeleteOptions{})
// Expect(err).To(BeNil(), fmt.Sprintf("Error creating Pod %v", err))
// })
// })
Context("when scheduling a read only busybox container", func() {
It("it should return success", func() {
isReadOnly := true
pod := &api.Pod{
ObjectMeta: api.ObjectMeta{
Name: "busybox",
Namespace: api.NamespaceDefault,
},
Spec: api.PodSpec{
// Force the Pod to schedule to the node without a scheduler running
NodeName: *nodeName,
// Don't restart the Pod since it is expected to exit
RestartPolicy: api.RestartPolicyNever,
Containers: []api.Container{
{
Image: "gcr.io/google_containers/busybox",
Name: "busybox",
Command: []string{"sh", "-c", "echo test > /file"},
SecurityContext: &api.SecurityContext{
ReadOnlyRootFilesystem: &isReadOnly,
},
},
},
},
}
_, err := cl.Pods(api.NamespaceDefault).Create(pod)
Expect(err).To(BeNil(), fmt.Sprintf("Error creating Pod %v", err))
})

It("it should not write to the root filesystem", func() {
Eventually(func() string {
rc, err := cl.Pods(api.NamespaceDefault).GetLogs("busybox", &api.PodLogOptions{}).Stream()
if err != nil {
return ""
}
defer rc.Close()
buf := new(bytes.Buffer)
buf.ReadFrom(rc)
return buf.String()
}, time.Second*30, time.Second*4).Should(Equal("sh: can't create /file: Read-only file system\n"))
})

It("it should be possible to delete", func() {
err := cl.Pods(api.NamespaceDefault).Delete("busybox", &api.DeleteOptions{})
Expect(err).To(BeNil(), fmt.Sprintf("Error creating Pod %v", err))
})
})
})

Describe("metrics api", func() {
Expand Down