Return success when registrying unhealthy node. #2239
Conversation
| @@ -61,7 +61,11 @@ func (rs *REST) Create(ctx api.Context, obj runtime.Object) (<-chan apiserver.RE | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| minion, err := rs.registry.GetMinion(ctx, minion.Name) | |||
| minionName := minion.Name | |||
| minion, err := rs.registry.GetMinion(ctx, minionName) | |||
There was a problem hiding this comment.
Why does GetMinion error out on the minion being unhealthy? IMO unhealthy should be a bit in the minion's state. ...I realize this would be a large change now that I say it.
There was a problem hiding this comment.
Because we can have a health registry on top of that.
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/master/master.go#L266
There was a problem hiding this comment.
Yeah, we should remove the healthy registry thingy and just have a controller doing health checks and setting a healthy bit, e.g., minion.State.Healthy = false. Then scheduler needs to pay attention to that...
There was a problem hiding this comment.
Corrent. That's part of the larger change I wanna make :)
At initial stage, I plan to have apiserver filter out unhealthy node to keep the interface the same, i.e. scheduler doesn't have to take care of filtering out unhealthy node. Later, we can use something similar to a selector. So scheduler can select healthy node, admin can find and diagonse unhealthy node. We can probabaly add more states later.
|
I don't like this solution but I'm willing to take it if a real fix is in the works and will take a while. |
|
LGTM |
Return success when registrying unhealthy node.
Fix #2192