-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the latest version of google-fluentd. #22539
Conversation
Labelling this PR as size/S |
Adding label:do-not-merge because PR changes docs prohibited to auto merge |
GCE e2e build/test passed for commit 906f12ec9bba8f0151486540007047aff8382b9d. |
It includes some performance improvements for parsing JSON (which is very important for us, since all Docker logs are JSON) as well as a couple new settings, like forcing of a flush of multiline logs after a time period rather than having to wait until a new log is seen before feeling confident flushing the previous one.
Removed the docs change. Here's to hoping verify-generated-docs has been turned off... |
@@ -9,7 +9,7 @@ spec: | |||
dnsPolicy: Default | |||
containers: | |||
- name: fluentd-cloud-logging | |||
image: gcr.io/google_containers/fluentd-gcp:1.17 | |||
image: gcr.io/google_containers/fluentd-gcp:1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you already pushed the images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and tested it)
GCE e2e build/test passed for commit 3216204. |
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
GCE e2e build/test passed for commit 3216204. |
Automatic merge from submit-queue |
Auto commit by PR queue bot
It includes some performance improvements for parsing JSON (which is
very important for us, since all Docker logs are JSON) as well as a
couple new settings, like forcing of a flush of multiline logs after a
time period rather than having to wait until a new log is seen before
feeling confident flushing the previous one.
It also adds the
buffer_queue_full_action
option, but I'm not as confident about how stable that is, so I've opened #22537 to track it.cc @jimmidyson in case we're able to similarly get an updated version of fluentd for fluentd-es. I unfortunately am pretty swamped with other things at the moment.
Fixes #19405