Flush conntrack state for removed/changed UDP Services #22573

freehan · 2016-03-05T01:07:53Z

fixes: #19029

googlebot · 2016-03-05T01:07:54Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

freehan · 2016-03-05T01:08:30Z

build/debian-iptables/Makefile

@@ -18,7 +18,8 @@ IMAGE = debian-iptables
 TAG = v1

 build:
-	docker build -t gcr.io/google_containers/$(IMAGE):$(TAG) .
+	#docker build -t gcr.io/google_containers/$(IMAGE):$(TAG) .


i will revert this once review is done and image pushed

k8s-bot · 2016-03-05T01:15:11Z

GCE e2e build/test failed for commit 7224fdcd836d22ca91d8bac1cfabd4ae0a85520c.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

eparis · 2016-03-09T16:18:39Z

Adding the v1.2 milestone. Starting later today cherrypick-candidate will be removed from any PR that doesn't set the milestone.

freehan · 2016-03-10T22:04:51Z

@googlebot I signed it!

k8s-bot · 2016-03-10T22:21:58Z

GCE e2e build/test passed for commit d1d997bdeeddef9fbece03cd65aac3a74f922e79.

k8s-bot · 2016-03-10T22:28:41Z

GCE e2e build/test passed for commit 0ac7ff35eccb8980f412227c0452f9cf5cc85fa5.

k8s-bot · 2016-03-10T23:21:12Z

GCE e2e build/test passed for commit 0ac7ff35eccb8980f412227c0452f9cf5cc85fa5.

k8s-bot · 2016-03-10T23:40:17Z

GCE e2e build/test passed for commit 615bd4ebc3cbf954243763d0a9f708549fbefda5.

freehan · 2016-03-11T07:15:06Z

Ping @thockin

ArtfulCoder · 2016-03-11T23:40:27Z

pkg/proxy/iptables/proxier.go

@@ -491,12 +498,18 @@ func (proxier *Proxier) OnEndpointsUpdate(allEndpoints []api.Endpoints) {
 	// Remove endpoints missing from the update.
 	for name := range proxier.endpointsMap {
 		if !activeEndpoints[name] {
+			// record endpoints of unactive service to stale connections


do we handle the case : no endpoints deleted, but a service got deleted ?

Good Catch! Added logic to clean up stale service connections

k8s-bot · 2016-03-12T01:14:54Z

GCE e2e build/test failed for commit b6c3285d87a74b1dd83c81f3c37acc9166b3d666.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot · 2016-04-19T23:40:33Z

GCE e2e build/test passed for commit ad8c677.

k8s-github-robot · 2016-04-20T03:29:35Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-04-20T04:06:30Z

GCE e2e build/test passed for commit ad8c677.

k8s-github-robot · 2016-04-20T04:06:44Z

Automatic merge from submit-queue

zmerlynn · 2016-04-20T05:34:14Z

@freehan: Please create a cherrypick PR for this tomorrow if possible, if you want this included in 1.2.3.

zmerlynn · 2016-04-20T20:00:07Z

I tried to create a cherrypick for this as well, and it's going to need some work:

+++ Conflicts detected:

UU build/common.sh
UU build/debian-iptables/Dockerfile
UU build/debian-iptables/Makefile
UU pkg/proxy/iptables/proxier.go

freehan · 2016-04-20T20:20:10Z

@zmerlynn Thanks for reminding!

…3-upstream-release-1.2 Automated cherry pick of #22573

k8s-cherrypick-bot · 2016-04-21T00:09:10Z

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

…k-of-#22573-upstream-release-1.2 Automated cherry pick of kubernetes#22573

Fixes #157 kubernetes/kubernetes#19029 kubernetes/kubernetes#22573

…tration Fix case when operator fight with CRD registration on quota.openshift.io Origin-commit: 938b9768795281709c1f1e2ac6112e8573bd97ab

googlebot added the cla: no label Mar 5, 2016

freehan reviewed Mar 5, 2016
View reviewed changes

freehan assigned thockin Mar 5, 2016

k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 5, 2016

freehan added cla: yes and removed cla: no labels Mar 5, 2016

eparis added this to the v1.2 milestone Mar 9, 2016

freehan force-pushed the udpproxy branch from 7224fdc to d1d997b Compare March 10, 2016 21:47

googlebot added cla: no and removed cla: yes labels Mar 10, 2016

freehan force-pushed the udpproxy branch from d1d997b to 0ac7ff3 Compare March 10, 2016 21:54

freehan force-pushed the udpproxy branch from 0ac7ff3 to 615bd4e Compare March 10, 2016 23:01

ArtfulCoder reviewed Mar 11, 2016
View reviewed changes

bgrant0607 added cla: human-approved and removed cla: no labels Mar 12, 2016

freehan force-pushed the udpproxy branch from 615bd4e to b6c3285 Compare March 12, 2016 01:10

googlebot added the cla: no label Mar 12, 2016

k8s-github-robot merged commit 3b2aae8 into kubernetes:master Apr 20, 2016

zmerlynn added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 20, 2016

freehan mentioned this pull request Apr 20, 2016

Automated cherry pick of #22573 #24566

Merged

zmerlynn added a commit that referenced this pull request Apr 21, 2016

Merge pull request #24566 from freehan/automated-cherry-pick-of-#2257…

6652423

…3-upstream-release-1.2 Automated cherry pick of #22573

k8s-cherrypick-bot removed the cherrypick-candidate label Apr 21, 2016

j-vizcaino mentioned this pull request May 30, 2016

hyperkube image is missing the 'conntrack' utility #26515

Closed

This was referenced May 31, 2016

Add conntrack to the iso kubernetes/minikube#136

Closed

Add conntrack to hyperkube #26839

Merged

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016

Merge pull request kubernetes#24566 from freehan/automated-cherry-pic…

bf4766a

…k-of-#22573-upstream-release-1.2 Automated cherry pick of kubernetes#22573

jfoy mentioned this pull request Jan 13, 2017

Bug fix. Incoming UDP packets not reach newly deployed services #32561

Merged

shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017

Merge pull request kubernetes#24566 from freehan/automated-cherry-pic…

8239bae

…k-of-#22573-upstream-release-1.2 Automated cherry pick of kubernetes#22573

mqliang mentioned this pull request Sep 11, 2017

flush conntrack state for removed/changed UDP Services cloudnativelabs/kube-router#157

Closed

cmluciano mentioned this pull request Dec 6, 2017

KubeProxy does not delete connections for traffic to NodePort Service if the backend changes. #42473

Closed

murali-reddy added a commit to cloudnativelabs/kube-router that referenced this pull request Dec 24, 2017

Flush conntrack entry when UDP service endpoint is deleted

f424e1a

Fixes #157 kubernetes/kubernetes#19029 kubernetes/kubernetes#22573

murali-reddy mentioned this pull request Dec 24, 2017

Flush conntrack entry when UDP service endpoint is deleted cloudnativelabs/kube-router#259

Merged

murali-reddy added a commit to cloudnativelabs/kube-router that referenced this pull request Dec 24, 2017

Flush conntrack entry when UDP service endpoint is deleted (#259)

94a2ec7

Fixes #157 kubernetes/kubernetes#19029 kubernetes/kubernetes#22573

johanneswuerbach mentioned this pull request Aug 20, 2018

conntrack util not installed kubernetes/kops#5671

Closed

KomorkinMikhail mentioned this pull request Oct 19, 2018

Conntrack entities for SCTP are not flushed for deleted Service endpoints #70020

Closed

andrewsykim mentioned this pull request Oct 31, 2019

kube-proxy clean udp conntrack after node network resumed #84438

Closed

aojea mentioned this pull request Jun 14, 2020

WIP improve kube-proxy conntrack resilience #92122

Closed

rakeshdatta mentioned this pull request Aug 3, 2023

kube-proxy still routing to dead coredns endpoint #119750

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flush conntrack state for removed/changed UDP Services #22573

Flush conntrack state for removed/changed UDP Services #22573

freehan commented Mar 5, 2016

googlebot commented Mar 5, 2016

freehan Mar 5, 2016

k8s-bot commented Mar 5, 2016

eparis commented Mar 9, 2016

freehan commented Mar 10, 2016

k8s-bot commented Mar 10, 2016

k8s-bot commented Mar 10, 2016

k8s-bot commented Mar 10, 2016

k8s-bot commented Mar 10, 2016

freehan commented Mar 11, 2016

ArtfulCoder Mar 11, 2016

freehan Mar 12, 2016

k8s-bot commented Mar 12, 2016

k8s-bot commented Apr 19, 2016

k8s-github-robot commented Apr 20, 2016

k8s-bot commented Apr 20, 2016

k8s-github-robot commented Apr 20, 2016

zmerlynn commented Apr 20, 2016

zmerlynn commented Apr 20, 2016

freehan commented Apr 20, 2016

k8s-cherrypick-bot commented Apr 21, 2016

Flush conntrack state for removed/changed UDP Services #22573

Flush conntrack state for removed/changed UDP Services #22573

Conversation

freehan commented Mar 5, 2016

googlebot commented Mar 5, 2016

freehan Mar 5, 2016

Choose a reason for hiding this comment

k8s-bot commented Mar 5, 2016

eparis commented Mar 9, 2016

freehan commented Mar 10, 2016

k8s-bot commented Mar 10, 2016

k8s-bot commented Mar 10, 2016

k8s-bot commented Mar 10, 2016

k8s-bot commented Mar 10, 2016

freehan commented Mar 11, 2016

ArtfulCoder Mar 11, 2016

Choose a reason for hiding this comment

freehan Mar 12, 2016

Choose a reason for hiding this comment

k8s-bot commented Mar 12, 2016

k8s-bot commented Apr 19, 2016

k8s-github-robot commented Apr 20, 2016

k8s-bot commented Apr 20, 2016

k8s-github-robot commented Apr 20, 2016

zmerlynn commented Apr 20, 2016

zmerlynn commented Apr 20, 2016

freehan commented Apr 20, 2016

k8s-cherrypick-bot commented Apr 21, 2016