etcd v3 initial change #22604

hongchaodeng · 2016-03-06T01:33:42Z

This serves as a follow up on #22448.

The conversation is good! Let's keep it up while working out some real code.

I'm initiating a few things here:

bump up etcd godep. The etcd would support both V2 and V3 API for us to do the work. Minor fix is done on EtcdtestServer.
I set up the structure of etcd3 helper and implements Set(), Get().

k8s-bot · 2016-03-06T01:38:18Z

GCE e2e build/test failed for commit 21b84e806130aae5d328a98cde3aea80e1582c72.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-github-robot · 2016-03-06T01:39:27Z

Labelling this PR as size/XS

k8s-bot · 2016-03-06T01:44:10Z

GCE e2e build/test failed for commit af90a13f0a14bc3ff8f17a787397bfa6ad6c27b7.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot · 2016-03-06T03:42:28Z

GCE e2e build/test failed for commit 3afddb73ad53e2d4bb8e741a9248792c556ecb3a.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot · 2016-03-06T06:26:18Z

GCE e2e build/test failed for commit 03719896063dce058eb90b60d59665810e116a2e.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

wojtek-t · 2016-03-07T07:39:01Z

@hongchaodeng - can you please move Godeps update to a separate PR? It would be so much easier to review this PR then, because github doesn't support well PRs with so many files...

Also, I assume that with upgraded Godeps, etcd v2 in current setup will still work, right?

k8s-bot · 2016-03-11T20:28:46Z

GCE e2e build/test failed for commit 03719896063dce058eb90b60d59665810e116a2e.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

timothysc · 2016-03-11T20:31:06Z

@hongchaodeng could you squash the helper commits please, I can review 2-day.

wojtek-t · 2016-03-11T20:37:43Z

@timothysc - I didn't review this, just because we don't want to have it in 1.2. We are explicitly not merging big changes that are not going to be picked to 1.2 now.

timothysc · 2016-03-11T20:39:11Z

@wojtek-t no worries, I had some time so just getting back into the fray, and wanted to keep an eye on this one.

k8s-bot · 2016-03-12T00:46:30Z

GCE e2e build/test failed for commit 66d6e033afe8f896ad8a575799a63cd3f5b850da.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot · 2016-03-12T01:21:22Z

GCE e2e build/test failed for commit d2be21e37b440455b03d36730e6d425e813a6f6e.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

hongchaodeng · 2016-03-12T04:23:49Z

I am constantly getting verify error:

output binaries contain bad symbols "testing[.]"
!!! Error in ./hack/../hack/verify-symbols.sh:28
  '"${KUBE_ROOT}/hack/after-build/verify-symbols.sh"' exited with status 1
Call stack:
  1: ./hack/../hack/verify-symbols.sh:28 main(...)
Exiting with status 1
FAILED   ./hack/../hack/verify-symbols.sh

@timothysc Can you help with that?

k8s-bot · 2016-03-12T04:26:27Z

GCE e2e build/test failed for commit 295749b5f50c3a6439e3f0c8e54c67ecb3c76820.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-bot · 2016-03-12T04:35:56Z

GCE e2e build/test failed for commit 21f089f27f94440ce6713630168f368c411cfaa1.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

wojtek-t · 2016-03-18T12:16:35Z

I've added few comments.

@hongchaodeng Can't we merge first two commits as a separate PR? We could do it now.

hongchaodeng · 2016-03-18T16:55:35Z

@wojtek-t
Separate out the first two commits: #23194

Some deps are missing there because we only use them in v3 helper commits. But they are pretty minor.

hongchaodeng · 2016-03-18T23:15:31Z

Add last commit "add custom storage error".
It abstracts away etcd-specific implementation of errors.
It's up to implementation re. how to parse error details and return storage errors.

/cc @xiang90 @wojtek-t @timothysc

k8s-bot · 2016-03-18T23:43:14Z

GCE e2e build/test passed for commit d94084710cb0de99de0d0ddf44306f43cff4a8f4.

k8s-bot · 2016-03-18T23:58:14Z

GCE e2e build/test passed for commit 39cfb67582b0b46f98d670fa2cd2141126e20861.

k8s-bot · 2016-03-19T05:49:29Z

GCE e2e build/test passed for commit 6ce4bb038b2541080fa70f823f4f3b82624122ef.

xiang90 · 2016-03-19T06:29:53Z

pkg/storage/etcd/etcd_helper.go

@@ -711,3 +710,21 @@ func (h *etcdHelper) addToCache(index uint64, obj runtime.Object) {
 		metrics.ObserveNewEntry()
 	}
 }
+
+func convertToStorageErrorIfPossible(err error, key string, rv uint64) error {


just ToStorageErr?

is this an etcd specific func? or we might add other potential kv error types into switch cases?

"storage/" handles only four errors in special. See here.

Not sure about other error types ATM.

k8s-github-robot · 2016-03-19T13:54:25Z

@hongchaodeng PR needs rebase

k8s-github-robot · 2016-03-19T16:42:23Z

Labelling this PR as size/L

k8s-bot · 2016-03-19T17:12:41Z

GCE e2e build/test passed for commit 97a1ed882ce2afaebbd79e81b0a26ac50dee6169.

k8s-bot · 2016-03-19T17:14:46Z

GCE e2e build/test passed for commit e0ee1e0846ad3120f10b6aa9c129340062af4a04.

k8s-bot · 2016-03-19T17:49:59Z

GCE e2e build/test passed for commit bc8a262.

hongchaodeng · 2016-03-20T05:47:39Z

Rebased and addressed comments.

hongchaodeng · 2016-03-21T20:29:43Z

I moved out the storage error commit into another PR (#23295) for easy review. PTAL.

hongchaodeng · 2016-03-23T06:28:31Z

This PR is way too long.

It's github's problem -- They should have better ways to show long discussion.

Anyway, I'm gonna closing this. Once #23295 is merged, I will rebase and submit another PR with more KV methods and improvement of code quality.

hongchaodeng · 2016-03-23T17:34:05Z

Created a new PR #23387

googlebot added the cla: yes label Mar 6, 2016

k8s-github-robot assigned davidopp Mar 6, 2016

k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2016

hongchaodeng force-pushed the e branch from 21b84e8 to af90a13 Compare March 6, 2016 01:40

hongchaodeng mentioned this pull request Mar 6, 2016

Upgrade to etcd v3 plan #22448

Closed

davidopp assigned wojtek-t and unassigned davidopp Mar 6, 2016

hongchaodeng mentioned this pull request Mar 6, 2016

constant 10737418240 overflows int etcd-io/etcd#4700

Closed

hongchaodeng force-pushed the e branch from 3afddb7 to 0371989 Compare March 6, 2016 06:22

hongchaodeng mentioned this pull request Mar 9, 2016

[DO NOT MERGE] Bump up godep of etcd to use V3 API #22731

Closed

hongchaodeng force-pushed the e branch from 0371989 to 66d6e03 Compare March 12, 2016 00:12

hongchaodeng force-pushed the e branch from 66d6e03 to d2be21e Compare March 12, 2016 01:13

hongchaodeng force-pushed the e branch 2 times, most recently from 295749b to 21f089f Compare March 12, 2016 04:04

hongchaodeng mentioned this pull request Mar 12, 2016

verify-symbols.sh complained error when importing etcd/clientv3 #22908

Closed

hongchaodeng mentioned this pull request Mar 18, 2016

Bump up godep of etcd to use V3 API #23194

Merged

hongchaodeng force-pushed the e branch from 4573883 to d940847 Compare March 18, 2016 23:02

hongchaodeng force-pushed the e branch from 39cfb67 to 6ce4bb0 Compare March 19, 2016 05:16

xiang90 reviewed Mar 19, 2016
View reviewed changes

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2016

hongchaodeng force-pushed the e branch from 6ce4bb0 to 97a1ed8 Compare March 19, 2016 16:33

godep: add clientv3 and integration

5a761c4

hongchaodeng force-pushed the e branch from 97a1ed8 to e0ee1e0 Compare March 19, 2016 16:36

k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2016

hongchaodeng added 2 commits March 19, 2016 10:15

etcd V3 helper: implements Set(), Get()

cf0c136

add custom storage error

bc8a262

hongchaodeng force-pushed the e branch from e0ee1e0 to bc8a262 Compare March 19, 2016 17:15

hongchaodeng closed this Mar 23, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

etcd v3 initial change #22604

etcd v3 initial change #22604

hongchaodeng commented Mar 6, 2016

k8s-bot commented Mar 6, 2016

k8s-github-robot commented Mar 6, 2016

k8s-bot commented Mar 6, 2016

k8s-bot commented Mar 6, 2016

k8s-bot commented Mar 6, 2016

wojtek-t commented Mar 7, 2016

k8s-bot commented Mar 11, 2016

timothysc commented Mar 11, 2016

wojtek-t commented Mar 11, 2016

timothysc commented Mar 11, 2016

k8s-bot commented Mar 12, 2016

k8s-bot commented Mar 12, 2016

hongchaodeng commented Mar 12, 2016

k8s-bot commented Mar 12, 2016

k8s-bot commented Mar 12, 2016

wojtek-t commented Mar 18, 2016

hongchaodeng commented Mar 18, 2016

hongchaodeng commented Mar 18, 2016

k8s-bot commented Mar 18, 2016

k8s-bot commented Mar 18, 2016

k8s-bot commented Mar 19, 2016

xiang90 Mar 19, 2016

xiang90 Mar 19, 2016

hongchaodeng Mar 19, 2016

k8s-github-robot commented Mar 19, 2016

k8s-github-robot commented Mar 19, 2016

k8s-bot commented Mar 19, 2016

k8s-bot commented Mar 19, 2016

k8s-bot commented Mar 19, 2016

hongchaodeng commented Mar 20, 2016

hongchaodeng commented Mar 21, 2016

hongchaodeng commented Mar 23, 2016

hongchaodeng commented Mar 23, 2016

etcd v3 initial change #22604

etcd v3 initial change #22604

Conversation

hongchaodeng commented Mar 6, 2016

k8s-bot commented Mar 6, 2016

k8s-github-robot commented Mar 6, 2016

k8s-bot commented Mar 6, 2016

k8s-bot commented Mar 6, 2016

k8s-bot commented Mar 6, 2016

wojtek-t commented Mar 7, 2016

k8s-bot commented Mar 11, 2016

timothysc commented Mar 11, 2016

wojtek-t commented Mar 11, 2016

timothysc commented Mar 11, 2016

k8s-bot commented Mar 12, 2016

k8s-bot commented Mar 12, 2016

hongchaodeng commented Mar 12, 2016

k8s-bot commented Mar 12, 2016

k8s-bot commented Mar 12, 2016

wojtek-t commented Mar 18, 2016

hongchaodeng commented Mar 18, 2016

hongchaodeng commented Mar 18, 2016

k8s-bot commented Mar 18, 2016

k8s-bot commented Mar 18, 2016

k8s-bot commented Mar 19, 2016

xiang90 Mar 19, 2016

Choose a reason for hiding this comment

xiang90 Mar 19, 2016

Choose a reason for hiding this comment

hongchaodeng Mar 19, 2016

Choose a reason for hiding this comment

k8s-github-robot commented Mar 19, 2016

k8s-github-robot commented Mar 19, 2016

k8s-bot commented Mar 19, 2016

k8s-bot commented Mar 19, 2016

k8s-bot commented Mar 19, 2016

hongchaodeng commented Mar 20, 2016

hongchaodeng commented Mar 21, 2016

hongchaodeng commented Mar 23, 2016

hongchaodeng commented Mar 23, 2016