Use LC_ALL=C with sort (again) in update-godep-licenses.sh #22892
Conversation
Also update LICENSES based on this ordering.
This reverts commit 991f744.
|
LGTM |
|
The LICENSES diff is a bit unwieldy: https://gist.github.com/ixdy/8b1dc614c0f73d165f12 |
|
LICENSES is a single file sourcing updates from 228+ packages from the interwebs. They can and do change. Expect much churn in that file as we keep it up to date and the lawyer cats happy! |
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
GCE e2e build/test passed for commit 51f70b6. |
eparis
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 51f70b6. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 51f70b6. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 51f70b6. |
|
Automatic merge from submit-queue |
Auto commit by PR queue bot
|
👍 |
This is similar to #22812, but makes the other
sortcall (which sorts the list of local files to consider) stable across locale environments. This is the root cause of #22843 which was causinghack/verify-godep-licenses.shto fail on Jenkins.This PR also re-enables the godep-licenses check on Jenkins.
Fixes #22843
cc @david-mcmahon @karlkfi @eparis