Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Fix problems with >2 security groups #23340

Merged
merged 1 commit into from
Mar 29, 2016
Merged

AWS: Fix problems with >2 security groups #23340

merged 1 commit into from
Mar 29, 2016

Conversation

justinsb
Copy link
Member

The previous logic was incorrect; if we saw two untagged security groups
before seeing the first tagged security, we would incorrectly return an
error.

Fix #23339

@justinsb
AWS: Fix problems with >2 security groups
59013f5 
The previous logic was incorrect; if we saw two untagged security groups
before seeing the first tagged security, we would incorrectly return an
error.

Fix kubernetes#23339
@justinsb justinsb added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/platform/aws labels Mar 22, 2016
@justinsb
Copy link
Member Author

cc @einyx

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@justinsb justinsb added this to the v1.2 milestone Mar 22, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 22, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 22, 2016

GCE e2e build/test failed for commit 59013f5.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@k8s-github-robot
Copy link

@justinsb
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-bot
Copy link

k8s-bot commented Mar 22, 2016

GCE e2e build/test passed for commit 59013f5.

@eparis eparis assigned davidopp and unassigned davidopp Mar 23, 2016
@eparis
Copy link
Contributor

eparis commented Mar 23, 2016

Apologies for the assignment spam. I was trying to debug the assignment tool and why it wasn't working right/well on this PR. Turns out, justin is both the author and the only potential assignee, so it gets grumpy.

@davidopp
Copy link
Member

LGTM

Sorry I didn't see this sooner

@davidopp davidopp added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Mar 29, 2016
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Mar 29, 2016

GCE e2e build/test passed for commit 59013f5.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 0c06f31 into kubernetes:master Mar 29, 2016
@bgrant0607 bgrant0607 added release-note Denotes a PR that will be considered when it comes time to generate release notes. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 30, 2016
@bgrant0607
Copy link
Member

@justinsb Please create a cherrypick PR ASAP if you'd like this in the next release.

@justinsb justinsb mentioned this pull request Apr 1, 2016
Merged
@justinsb
Copy link
Member Author

justinsb commented Apr 1, 2016

Opened #23718 as a cherry-pick

k8s-github-robot pushed a commit that referenced this pull request Apr 1, 2016
Merge pull request #23718 from justinsb/automated-cherry-pick-of-#233…
60bda7b 
…40-upstream-release-1.2

Automatic merge from submit-queue

Automated cherry pick of #23340

Cherry pick of #23340 on release-1.2.
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#23718 from justinsb/automated-cherry-pi…
0eca3c7 
…ck-of-#23340-upstream-release-1.2

Automatic merge from submit-queue

Automated cherry pick of kubernetes#23340

Cherry pick of kubernetes#23340 on release-1.2.
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
Merge pull request kubernetes#23718 from justinsb/automated-cherry-pi…
7b0fd08 
…ck-of-#23340-upstream-release-1.2

Automatic merge from submit-queue

Automated cherry pick of kubernetes#23340

Cherry pick of kubernetes#23340 on release-1.2.
@jjo jjo mentioned this pull request May 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@justinsb @k8s-cherrypick-bot @k8s-github-robot @k8s-bot @eparis @davidopp @bgrant0607 @k8s-teamcity-mesosphere @googlebot @wojtek-t