Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heapster patch release to 1.0.2 #23487

Merged
merged 1 commit into from
Mar 31, 2016

Conversation

piosz
Copy link
Member

@piosz piosz commented Mar 25, 2016

Updates to Heapster to 1.0.2. The release is described https://github.com/kubernetes/heapster/releases/tag/v1.0.2

The problems which were fixed:

  • lack of label required by GKE to draw graphs (xref b/27899686)
  • wrong method of comparing timestamps while converting cumulative metrics to corresponding rates ones which may lead for example to broke HPA
  • flaky GCE metadata server which may cause lack of metrics in GCM on GCE (metadata.OnGCE is flaky googleapis/google-cloud-go#194)

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 25, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2016
@piosz
Copy link
Member Author

piosz commented Mar 25, 2016

In HEAD I've already bumped Heapster to v1.1.0-beta1 and we don't want to cherry-pick it to release-1.2 so created a direct commit.

cc @bgrant0607 @fgrzadkowski @mwielgus

@k8s-bot
Copy link

k8s-bot commented Mar 25, 2016

GCE e2e build/test passed for commit 18573090e2883860f73bc521299cea393ffb0212.

@mwielgus
Copy link
Contributor

LGTM

@mwielgus mwielgus added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2016
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Mar 27, 2016

GCE e2e build/test passed for commit 18573090e2883860f73bc521299cea393ffb0212.

@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Mar 29, 2016

GCE e2e build/test passed for commit 18573090e2883860f73bc521299cea393ffb0212.

@piosz
Copy link
Member Author

piosz commented Mar 29, 2016

ping @bgrant0607
Are you ok to merge this?

@bgrant0607
Copy link
Member

Yes, but needs a release note.

@bgrant0607 bgrant0607 added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 29, 2016
@bgrant0607
Copy link
Member

What critical bug does this fix? Ref to issue?

@bgrant0607
Copy link
Member

@piosz Any info re. why we need this?

@bgrant0607 bgrant0607 removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2016
@bgrant0607
Copy link
Member

@piosz @mwielgus I'm not merging this without explanation.

@piosz piosz changed the title Heapster patch release to 1.0.1 Heapster patch release to 1.0.2 Mar 31, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 31, 2016

GCE e2e build/test passed for commit 793d91a.

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@piosz
Copy link
Member Author

piosz commented Mar 31, 2016

@bgrant0607 apologies for the delay but I was traveling.

I've changed the PR to bump Heapster to 1.0.2. The problems which were fixed:

  • lack of label required by GKE to draw graphs (xref b/27899686)
  • wrong method of comparing timestamps while converting cumulative metrics to corresponding rates ones which may lead for example to broke HPA
  • flaky GCE metadata server which may cause lack of metrics in GCM on GCE (metadata.OnGCE is flaky googleapis/google-cloud-go#194)

cc @a-robinson

@k8s-github-robot
Copy link

@piosz
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@bgrant0607
Copy link
Member

@piosz Thanks for the details. In the future, please put them in the description -- the first section.

@bgrant0607
Copy link
Member

LGTM

@bgrant0607 bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 31, 2016
@bgrant0607
Copy link
Member

Will merge once tests pass.

@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 31, 2016
@piosz
Copy link
Member Author

piosz commented Mar 31, 2016

Thanks @bgrant0607

@bgrant0607
Copy link
Member

Green. Merging.

@bgrant0607 bgrant0607 merged commit 9c9d69e into kubernetes:release-1.2 Mar 31, 2016
@bgrant0607 bgrant0607 removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 31, 2016
@piosz piosz deleted the heapster-1.0.1 branch April 1, 2016 04:57
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants