Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the correct api endpoint for gke prod. #23507

Merged
merged 1 commit into from
Mar 25, 2016
Merged

Set the correct api endpoint for gke prod. #23507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions hack/jenkins/job-configs/kubernetes-jenkins/kubernetes-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@
export PROJECT="k8s-jkns-e2e-gke-prod"
export CLOUDSDK_BUCKET="gs://cloud-sdk-testing/rc"
export JENKINS_USE_SERVER_VERSION="y"
export CLOUDSDK_API_ENDPOINT_OVERRIDES_CONTAINER="https://container.googleapis.com/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes me wonder whether the global default should be the test endpoint or prod.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my other PR I clearly had assumed that the default was prod. But the test endpoint makes sense in terms of less configuration since the vast majority of our tests use that endpoint.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the default used to be prod. I guess as long as we've audited all places we expected this to be prod, we're probably OK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just these two. And I double-checked that the two staging tests were set correctly as well.

export ZONE="asia-east1-b"
- 'gke-prod-parallel':
description: 'Run E2E tests on GKE prod endpoint in parallel.'
Expand All @@ -391,6 +392,7 @@
export PROJECT="k8s-e2e-gke-prod-parallel"
export CLOUDSDK_BUCKET="gs://cloud-sdk-testing/rc"
export JENKINS_USE_SERVER_VERSION="y"
export CLOUDSDK_API_ENDPOINT_OVERRIDES_CONTAINER="https://container.googleapis.com/"
export GINKGO_TEST_ARGS="--ginkgo.skip=\[Slow\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\]"
export GINKGO_PARALLEL="y"
export ZONE="asia-east1-b"
Expand Down